-
Notifications
You must be signed in to change notification settings - Fork 443
Fix gh aw add parsing for long hyphenated repository names
#37960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -352,11 +352,15 @@ func ParseRepoFileURL(fileURL string) (owner, repo, ref, filePath string, err er | |
| } | ||
| } | ||
|
|
||
| // IsValidGitHubIdentifier checks if a string is a valid GitHub username or repository name | ||
| func IsValidGitHubIdentifier(s string) bool { | ||
| // GitHub identifiers can contain alphanumeric characters, hyphens, and underscores | ||
| // They cannot start or end with a hyphen and must be 1-39 characters long | ||
| if len(s) == 0 || len(s) > 39 { | ||
| const ( | ||
| maxGitHubOwnerIdentifierLength = 39 | ||
| maxGitHubRepositoryNameLength = 100 | ||
| ) | ||
|
|
||
| func isValidGitHubNameWithMaxLength(s string, maxLength int) bool { | ||
| // GitHub identifiers can contain alphanumeric characters, hyphens, and underscores. | ||
| // They cannot start or end with a hyphen. | ||
| if len(s) == 0 || len(s) > maxLength { | ||
| return false | ||
| } | ||
| if s[0] == '-' || s[len(s)-1] == '-' { | ||
|
|
@@ -369,3 +373,13 @@ func IsValidGitHubIdentifier(s string) bool { | |
| } | ||
| return true | ||
| } | ||
|
|
||
| // IsValidGitHubIdentifier checks if a string is a valid GitHub user or organization identifier. | ||
| func IsValidGitHubIdentifier(s string) bool { | ||
| return isValidGitHubNameWithMaxLength(s, maxGitHubOwnerIdentifierLength) | ||
| } | ||
|
Comment on lines
+377
to
+380
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated in |
||
|
|
||
| // IsValidGitHubRepositoryName checks if a string is a valid GitHub repository name. | ||
| func IsValidGitHubRepositoryName(s string) bool { | ||
| return isValidGitHubNameWithMaxLength(s, maxGitHubRepositoryNameLength) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in
e31d8ee.pkg/cli/spec_github_url_test.gonow includes aparseGitHubURLregression case with a long hyphenated repo segment (>39 chars).