Skip to content

docs: remove transparent border-bottom preset from link buttons on slides page#25233

Merged
mnkiefer merged 1 commit into
mainfrom
copilot/remove-hidden-lower-border
Apr 8, 2026
Merged

docs: remove transparent border-bottom preset from link buttons on slides page#25233
mnkiefer merged 1 commit into
mainfrom
copilot/remove-hidden-lower-border

Conversation

Copilot AI commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Starlight's .sl-markdown-content a rule applied border-bottom: 1px solid transparent to all links, including LinkButton components. This left an invisible border on the buttons that was unintended.

Change

Scoped the border-bottom rule away from .sl-link-button elements:

/* Before */
.sl-markdown-content a { border-bottom: 1px solid transparent; }

/* After */
.sl-markdown-content a:not(.sl-link-button) { border-bottom: 1px solid transparent; }

…in slides page

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5b82e239-77a0-4a33-ac81-08284634494d

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review April 8, 2026 04:27
Copilot AI review requested due to automatic review settings April 8, 2026 04:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts docs CSS so the markdown link underline/border styling does not apply to Starlight LinkButton components, avoiding an unintended invisible border-bottom on those buttons.

Changes:

  • Scope .sl-markdown-content a styling to exclude .sl-link-button via :not(.sl-link-button).
Show a summary per file
File Description
docs/src/styles/custom.css Excludes .sl-link-button anchors from the markdown link border-bottom styling.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@mnkiefer mnkiefer merged commit babd7c1 into main Apr 8, 2026
11 checks passed
@mnkiefer mnkiefer deleted the copilot/remove-hidden-lower-border branch April 8, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants