Skip to content

fix: spinner consumes stdin causing double-Enter required in add-wizard #24523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 2 commits into from
Apr 4, 2026
Merged

fix: spinner consumes stdin causing double-Enter required in add-wizard #24523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a9f6b
Initial plan
Copilot Apr 4, 2026
59e0ee9
fix: spinner reads from stdin causing double Enter in add-wizard
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/console/spinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ func NewSpinner(message string) *SpinnerWrapper {
message: message,
output: os.Stderr,
}
s.program = tea.NewProgram(model, tea.WithOutput(os.Stderr), tea.WithoutRenderer())
// tea.WithInput(nil) disables stdin reading so the spinner does not consume key
// events that should be handled by subsequent interactive forms (e.g. huh.Select).
// Ctrl+C is still handled via OS signal delivery (SIGINT), which bubbletea
// processes independently of the input reader.
s.program = tea.NewProgram(model, tea.WithOutput(os.Stderr), tea.WithoutRenderer(), tea.WithInput(nil))
Comment on lines +119 to +123

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes an interactive stdin issue but the enabled-spinner code path isn’t covered by the current spinner tests (they generally run with spinner disabled because stderr isn’t a TTY). Consider adding a regression test that simulates a TTY for stderr and verifies the spinner program does not consume bytes from os.Stdin while running (i.e., stdin remains readable for subsequent interactive prompts).

Copilot uses AI. Check for mistakes.
}
return s
}
Expand Down
Loading