Skip to content

fix: silently skip add_comment when no triggering context on schedule runs #24131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Apr 2, 2026
Merged

fix: silently skip add_comment when no triggering context on schedule runs #24131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd9854e
Initial plan
Copilot Apr 2, 2026
0307137
fix: silently skip add_comment when no triggering context (schedule r…
Copilot Apr 2, 2026
0dbe026
Merge branch 'main' into copilot/whm-fix-schedule-failures
pelikhan Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actions/setup/js/add_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ async function main(config = {}) {
core.warning(`Skipping add_comment: max count of ${maxCount} reached`);
return {
success: false,
skipped: true,
error: `Max count of ${maxCount} reached`,
};
}
Expand Down
1 change: 1 addition & 0 deletions actions/setup/js/add_comment.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2027,6 +2027,7 @@ describe("add_comment", () => {
expect(result1.success).toBe(true);
expect(result2.success).toBe(true);
expect(result3.success).toBe(false);
expect(result3.skipped).toBe(true);
expect(result3.error).toMatch(/max count/i);
});
});
Expand Down
10 changes: 7 additions & 3 deletions actions/setup/js/safe_output_handler_manager.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,7 @@ async function processMessages(messageHandlers, messages, onItemCreated = null)
// Skipped results should NOT trigger fail-fast cancellation of subsequent messages.
if (result && result.success === false && result.skipped === true && !result.deferred) {
const msg = result.error || "Handler returned success: false with skipped: true";
if (CODE_PUSH_TYPES.has(messageType)) {
core.info(`⏭ Message ${i + 1} (${messageType}) skipped — ${msg}`);
}
core.info(`⏭ Message ${i + 1} (${messageType}) skipped — ${msg}`);
results.push({
type: messageType,
messageIndex: i,
Expand Down Expand Up @@ -1090,6 +1088,7 @@ async function main() {
const skippedStandaloneResults = processingResult.results.filter(r => r.skipped && r.reason === "Handled by standalone step");
const skippedCustomJobResults = processingResult.results.filter(r => r.skipped && r.reason === "Handled by custom safe output job");
const skippedNoHandlerResults = processingResult.results.filter(r => !r.success && !r.skipped && r.error?.includes("No handler loaded"));
const skippedHandlerResults = processingResult.results.filter(r => r.skipped && !r.reason && !r.deferred && !r.cancelled);

core.info(`\n=== Processing Summary ===`);
core.info(`Total messages: ${processingResult.results.length}`);
Expand All @@ -1101,6 +1100,11 @@ async function main() {
if (deferredCount > 0) {
core.info(`Deferred: ${deferredCount}`);
}
if (skippedHandlerResults.length > 0) {
core.info(`Skipped (no context or limit reached): ${skippedHandlerResults.length}`);

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new skippedHandlerResults bucket is labeled as Skipped (no context or limit reached), but the filter (r.skipped && !r.reason && !r.deferred && !r.cancelled) will also include other handler-level skips that don’t set reason (e.g. code-push if_no_changes skips like “No patch file found…”), so the summary line can be misleading. Consider either (a) renaming this line to something generic like “Skipped (handler)” or (b) adding/propagating a structured reason for different skip causes (no-context / max-count / no-changes) and grouping the summary by that reason.

Suggested change
core.info(`Skipped (no context or limit reached): ${skippedHandlerResults.length}`);
core.info(`Skipped (handler): ${skippedHandlerResults.length}`);

Copilot uses AI. Check for mistakes.
const skippedHandlerTypes = [...new Set(skippedHandlerResults.map(r => r.type))];
core.info(` Types: ${skippedHandlerTypes.join(", ")}`);
}
if (skippedStandaloneResults.length > 0) {
core.info(`Skipped (standalone step): ${skippedStandaloneResults.length}`);
const standaloneTypes = [...new Set(skippedStandaloneResults.map(r => r.type))];
Expand Down
Loading