Skip to content

Fix tests broken by playwright allowed_domains removal #17645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix tests broken by playwright allowed_domains removal #17645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c27c4
Initial plan
Copilot Feb 22, 2026
68b428c
Fix tests: update codemod count and remove stale playwright allowed_d…
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cli/fix_codemods_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestGetAllCodemods_ReturnsAllCodemods(t *testing.T) {
codemods := GetAllCodemods()

// Verify we have the expected number of codemods
expectedCount := 22
expectedCount := 23
assert.Len(t, codemods, expectedCount, "Should return all %d codemods", expectedCount)

// Verify all codemods have required fields
Expand Down Expand Up @@ -126,6 +126,7 @@ func TestGetAllCodemods_InExpectedOrder(t *testing.T) {
"bots-to-on-bots",
"engine-steps-to-top-level",
"assign-to-agent-default-agent-to-name",
"playwright-allowed-domains-migration",
}

require.Len(t, codemods, len(expectedOrder), "Should have expected number of codemods")
Expand Down
6 changes: 0 additions & 6 deletions pkg/workflow/importable_tools_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ Uses imported playwright tool.
}

// Verify allowed domains are present
if !strings.Contains(workflowData, "example.com") {
t.Error("Expected compiled workflow to contain example.com domain")
}
if !strings.Contains(workflowData, "github.com") {
t.Error("Expected compiled workflow to contain github.com domain")
}
Expand Down Expand Up @@ -349,9 +346,6 @@ Uses all imported tools.
if !strings.Contains(workflowData, "ghcr.io/github/serena-mcp-server:latest") {
t.Error("Expected compiled workflow to contain serena Docker container")
}
if !strings.Contains(workflowData, "example.com") {
t.Error("Expected compiled workflow to contain example.com domain for playwright")
}
}

// TestImportSerenaWithLanguageConfig tests serena with detailed language configuration
Expand Down