[lint-monster] function-length refactoring backlog (662 findings in pkg/workflow and pkg/cli)

[github-actions]

Summary

Current make golint-custom reports 662 shared long-function findings across pkg/workflow and pkg/cli. This issue is the single authoritative tracker for the shared function-length refactoring backlog for this run.

Current count

• 662 total findings
• pkg/workflow: 284 findings
• pkg/cli: 378 findings

Representative diagnostics

• pkg/workflow/antigravity_engine.go:155: GetExecutionSteps is 204 lines long (limit: 60)
• pkg/workflow/awf_helpers.go:229: BuildAWFCommand is 372 lines long (limit: 60)
• pkg/workflow/compiler_safe_outputs_job.go:269: buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines long (limit: 60)
• pkg/cli/add_interactive_git.go:26: createWorkflowPRAndConfigureSecret is 171 lines long (limit: 60)
• pkg/cli/audit_diff.go:67: computeFirewallDiff is 144 lines long (limit: 60)

Expected outcome

Reduce this shared backlog with narrow, behavior-preserving refactors that extract cohesive helpers and shrink long functions incrementally.

Remediation checklist

• Work only on the shared pkg/workflow / pkg/cli function-length backlog
• Prefer minimal helper extraction and small file splits over broad rewrites
• Keep each PR focused on one subsystem slice at a time
• Re-count the backlog after each slice with make golint-custom
• Validate with make golint-custom

Next slices

• Engine execution step builders in pkg/workflow
• Safe outputs compilation/rendering helpers in pkg/workflow
• Checkout/config parsing helpers in pkg/workflow
• CLI interactive / audit command hotspots in pkg/cli

Duplicate tracking

• Existing related open tracker reviewed: [lint-monster] [Code Quality] Shared function-length refactoring backlog for pkg/workflow and pkg/cli (677 findings) #46514
• Recent closed related trackers reviewed: [lint-monster] [Code Quality] Shared function-length refactoring backlog for pkg/workflow and pkg/cli (680 findings) #46955, [lint-monster] function-length refactoring backlog (659 findings in pkg/workflow and pkg/cli) #47448
• This issue supersedes prior backlog snapshots for the current lint count because update_issue cannot target [lint-monster] [Code Quality] Shared function-length refactoring backlog for pkg/workflow and pkg/cli (677 findings) #46514 from this workflow context

Fused skill guidance

• Validate fixes by running make golint-custom
• Keep remediation scoped to findings in the assigned lint group
• Prefer minimal, targeted code edits

Generated by 🧌 LintMonster · gpt54 · 60.2 AIC · ⌖ 9.02 AIC · ⊞ 4.6K · ◷

• expires on Jul 31, 2026, 7:43 PM UTC-08:00

[github-actions]

🍪 Issue Monster selected this for Copilot

I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

🍪 Om nom nom by Issue Monster · gpt54 · 9.88 AIC · ⌖ 6.94 AIC · ⊞ 7.5K · ◷

[github-actions]

Closing as a duplicate of #48111, which is the single authoritative open tracker for the shared function-length refactoring backlog. The current lint run records 665 shared findings across pkg/workflow and pkg/cli, and that consolidated count is now maintained in #48111.

Generated by 🧌 LintMonster · gpt54 · 17.7 AIC · ⌖ 9.02 AIC · ⊞ 4.6K