Description
pkg/cli/logs_report_firewall.go declares two ~80%-overlapping summary structs:
AccessLogSummary (line ~11)
FirewallLogSummary (line ~21)
Both carry TotalRequests, allowed/blocked counters, AllowedDomains, BlockedDomains, and ByWorkflow. They differ only in counter field naming (AllowedCount/BlockedCount vs AllowedRequests/BlockedRequests) and one extra RequestsByDomain map on the firewall variant. Extract a shared base struct, align the counter field names, and embed it in both.
Expected Impact
Removes parallel-maintenance drift between two firewall summary types. Bounded, single-file refactor.
Suggested Agent
Code Quality agent (Go refactor).
Estimated Effort
Medium (1-2 hours)
Data Source
DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 4). Verified un-filed as of this run.
Generated by 🔬 Deep Report · 247.5 AIC · ⌖ 12.4 AIC · ⊞ 10K · ◷
Description
pkg/cli/logs_report_firewall.godeclares two ~80%-overlapping summary structs:AccessLogSummary(line ~11)FirewallLogSummary(line ~21)Both carry
TotalRequests, allowed/blocked counters,AllowedDomains,BlockedDomains, andByWorkflow. They differ only in counter field naming (AllowedCount/BlockedCountvsAllowedRequests/BlockedRequests) and one extraRequestsByDomainmap on the firewall variant. Extract a shared base struct, align the counter field names, and embed it in both.Expected Impact
Removes parallel-maintenance drift between two firewall summary types. Bounded, single-file refactor.
Suggested Agent
Code Quality agent (Go refactor).
Estimated Effort
Medium (1-2 hours)
Data Source
DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 4). Verified un-filed as of this run.