[aw] Impeccable Skills Reviewer failed

[github-actions]

Workflow Failure

Workflow: Impeccable Skills Reviewer
Branch: copilot/aw-fix-clt-hang-issue
Run: https://github.com/github/gh-aw/actions/runs/28989373685
Pull Request: #44440

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

Review submitted. Here's a summary:
### Review: PR #44440 — `REQUEST_CHANGES`
**One blocking correctness issue found:**
`missing_data` is absent from `NON_TERMINAL_SAFE_OUTPUT_TYPES` (line 150 of `copilot_harness.cjs`). Since `evaluate_outcomes.cjs` treats `missing_data` as a non-actionable/noop type (alongside `missing_tool` and `report_incomplete`), an agent that emits only a `missing_data` entry will incorrectly arm the post-result watchdog and get killed prematurely.
**Fix:** add `"missing_data"` to the set, and add a matching test case to `hasTerminalSafeOutput` suite.
Everything else looks solid — the watchdog design, SIGTERM→SIGKILL escalation, `settle()` cleanup, poll/grace bounds, and the test coverage for armed/unarmed paths are all correct.
Changes    +0 -0
Duration   13m 27s
Tokens     ↑ 765.0k (724.3k cached) • ↓ 54.3k
Resume     copilot --resume=7e226392-e63b-4785-960d-3a9af3edd9ad

Action Required

Assign this issue to an agent to debug and fix the issue.

Debug with any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://github.com/github/gh-aw/main/debug.md

The failed workflow run is at https://github.com/github/gh-aw/actions/runs/28989373685

Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

• Start your agent
• Load the agentic-workflows skill from .github/skills/agentic-workflows/SKILL.md or https://github.com/github/gh-aw/blob/main/.github/skills/agentic-workflows/SKILL.md
• Type debug the agentic workflow impeccable-skills-reviewer failure in https://github.com/github/gh-aw/actions/runs/28989373685

Tip

Stop reporting this workflow as a failure

To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
  report-failure-as-issue: false

Generated from Impeccable Skills Reviewer · 116 AIC · ◷

• expires on Jul 9, 2026, 2:38 PM UTC

[github-actions]

Agent job 28993342148 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

### Review of PR #44454
**Status: REQUEST_CHANGES**
The performance fix is sound and well-tested, but one blocking issue was found:
**`<<<` here-strings are misidentified as heredoc openers** (`detectHeredocDelimiter` line 101). `strings.Cut(trimmed, "<<")` matches the first two `<` of `<<<`, leaving `< value` as `after`. This produces delimiter `"<"`, causing `inHeredoc=true` permanently — all subsequent lines in the run block are silently skipped, including any unsafe `${{ }}` expressions.
This is confirmed real: `architecture-guardian.lock.yml` and `daily-performance-summary.lock.yml` both use `<<<` in multiline run blocks.
**Fix:** Add `if strings.HasPrefix(after, "<") { return "", false }` immediately after the `strings.Cut` check, plus a test case for `cmd <<< "$var"` → `("", false)`.
Changes    +0 -0
Duration   14m 1s
Tokens     ↑ 1.4m (1.3m cached) • ↓ 49.9k
Resume     copilot --resume=ef1e0ec3-7050-4a3f-8d8f-d3b193117dc3

Generated from Impeccable Skills Reviewer · 133.1 AIC · ◷

[github-actions]

Agent job 29013168076 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

### PR #44500 — Review complete (`COMMENT`)
**Overall**: Implementation is correct — union dedup semantics, `Disabled` guard, `MergeUnique` ordering, and integration test all look good.
**3 non-blocking issues flagged with inline comments:**
1. **`forbidden_fields_import_test.go` line 32** — stale `"sandbox"` entry in `forbiddenFieldYAML` is unreachable now that `"sandbox"` was removed from `SharedWorkflowForbiddenFields`.
2. **`constants.go` line 363** — comment should clarify that only `sandbox.agent.mounts` is merged from partials; all other `sandbox.agent.*` sub-fields are silently dropped.
3. **`import_field_extractor.go` line 405** — no test documents the intentional silent drop of a partial declaring `sandbox.agent: false`; a table-driven case would prevent future ambiguity.
Changes    +0 -0
Duration   14m 28s
Tokens     ↑ 1.4m (1.4m cached) • ↓ 53.3k
Resume     copilot --resume=b41a26e6-7a09-469b-a7b0-2a5a8c1e669f

Generated from Impeccable Skills Reviewer · 141.7 AIC · ◷

[github-actions]

This issue was automatically closed because it expired on 2026-07-09T14:38:12.507Z.

Closed by Workflow