[aw] Matt Pocock Skills Reviewer failed

[github-actions]

Workflow Failure

Workflow: Matt Pocock Skills Reviewer
Branch: copilot/extra-empty-commit-ci-trigger
Run: https://github.com/github/gh-aw/actions/runs/28987306542
Pull Request: #44180

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

  └ 30 lines…
Review complete. Here's what was submitted on PR #44180:
**Overall**: `REQUEST_CHANGES` — 6 inline comments across 4 files.
**Top issues found:**
1. 🔴 **Correctness bug** (`extra_empty_commit.cjs:155`): If `overridePersistedExtraheader`'s `git config --replace-all` throws, `previousExtraheaders` stays `[]` and `finally` runs `--unset-all`, destroying the original checkout credential that was never actually overwritten. Needs an `overrideApplied` guard flag.
2. 🔴 **Missing test** (`extra_empty_commit.test.cjs:185`): The `finally` restore path is untested for push failures — need a test that verifies auth state is restored even when `git push` throws.
3. 🟡 **`err.message` vs `getErrorMessage`** (`git_auth_helpers.cjs:68`): Inconsistent with the codebase standard; unsafe on non-`Error` rejections.
4. 🟡 **`silent: true` on security write** (`git_auth_helpers.cjs:73`): Suppresses stderr on the auth-overriding `git config` call, making failures hard to diagnose.
5. 🟢 **Double-normalization** (`git_auth_helpers.cjs:65`): `normalizedUrl` passed to `getExtraheaderValues` which normalizes again — ambiguous contract.
6. 🟢 **Hidden global coupling** (`git_auth_helpers.cjs:14`): `exec`/`core` relied on as implicit globals; fragile outside `github-script` runtime.

Action Required

Assign this issue to an agent to debug and fix the issue.

Debug with any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://github.com/github/gh-aw/main/debug.md

The failed workflow run is at https://github.com/github/gh-aw/actions/runs/28987306542

Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

• Start your agent
• Load the agentic-workflows skill from .github/skills/agentic-workflows/SKILL.md or https://github.com/github/gh-aw/blob/main/.github/skills/agentic-workflows/SKILL.md
• Type debug the agentic workflow mattpocock-skills-reviewer failure in https://github.com/github/gh-aw/actions/runs/28987306542

Tip

Stop reporting this workflow as a failure

To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
  report-failure-as-issue: false

Generated from Matt Pocock Skills Reviewer · 137.6 AIC · ◷

• expires on Jul 9, 2026, 1:40 PM UTC

[github-actions]

Agent job 28987186755 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

    at _rmdirSync (node:internal/fs/rimraf:251:7)
    at rimrafSync (node:internal/fs/rimraf:194:7)
    at node:internal/fs/rimraf:254:9
    at Array.forEach (<anonymous>)
    at _rmdirSync (node:internal/fs/rimraf:251:7) {
  errno: -13,
  code: 'EACCES',
  syscall: 'unlink',
  path: '/tmp/awf-1783560163096-chroot-home/.aws/config'
}

Generated from Matt Pocock Skills Reviewer · 119.6 AIC · ◷

[github-actions]

Agent job 28991457227 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

  │ "path": "actions/setup/js/extra_empty_commit.cjs",
  │ "line": 263,...
  └ 28 lines...
● Post comment 3: ambient global coupling for getOctokit (shell)
  │ cat > /tmp/gh-aw/agent/comment3.json << 'EOF'
  │ {
  │ "pull_request_number": 44180,
  │ "path": "actions/setup/js/extra_empty_commit.cjs",
  │ "line": 206,...
  └ 29 lines...

Generated from Matt Pocock Skills Reviewer · 144.1 AIC · ◷