Objective
Delete the first batch of permanently-skipped "zombie" test files from pkg/workflow/. These files contain test functions that all unconditionally call t.Skip() with a message like "scripts now use require() pattern to load external files at runtime". They provide zero coverage and should be removed.
Context
Discussion #19223 identified 31 test files across the repo with 93 permanently-skipped functions (1,756 lines of non-functional test code) left behind after an architectural migration where JS scripts moved from embedded/inlined to being loaded at runtime via require() from external files in actions/setup/js/. These files were never re-written or removed.
Files to Delete
Run git rm on these files:
git rm pkg/workflow/branch_normalize_integration_test.go
git rm pkg/workflow/codex_test.go
git rm pkg/workflow/comment_env_vars_conditional_test.go
git rm pkg/workflow/compiler_mcp_test.go
git rm pkg/workflow/compiler_reactions_test.go
git rm pkg/workflow/create_agent_session_integration_test.go
git rm pkg/workflow/create_issue_assignees_test.go
git rm pkg/workflow/create_issue_subissue_test.go
git rm pkg/workflow/create_pr_review_comment_test.go
git rm pkg/workflow/create_pull_request_allow_empty_test.go
git rm pkg/workflow/create_pull_request_reviewers_test.go
git rm pkg/workflow/github_context_test.go
git rm pkg/workflow/log_parser_docker_format_test.go
git rm pkg/workflow/log_parser_new_format_file_test.go
Important: Before deleting each file, verify it only contains permanently-skipped test functions (all functions call t.Skip()). If a file has any non-skipped test functions, do NOT delete it — only remove the skipped functions.
Approach
- For each file listed, open it and confirm ALL test functions are skipped with the require() migration message
- Run
git rm (file) for confirmed all-skip files
- Build and run tests to verify nothing breaks
Validation
go build ./...
go vet ./...
make fmt
make test-unit
Acceptance Criteria
Generated by Plan Command for issue #discussion #19223
Objective
Delete the first batch of permanently-skipped "zombie" test files from
pkg/workflow/. These files contain test functions that all unconditionally callt.Skip()with a message like"scripts now use require() pattern to load external files at runtime". They provide zero coverage and should be removed.Context
Discussion #19223 identified 31 test files across the repo with 93 permanently-skipped functions (1,756 lines of non-functional test code) left behind after an architectural migration where JS scripts moved from embedded/inlined to being loaded at runtime via
require()from external files inactions/setup/js/. These files were never re-written or removed.Files to Delete
Run
git rmon these files:Important: Before deleting each file, verify it only contains permanently-skipped test functions (all functions call
t.Skip()). If a file has any non-skipped test functions, do NOT delete it — only remove the skipped functions.Approach
git rm (file)for confirmed all-skip filesValidation
Acceptance Criteria
make test-unitpasses with no regressions