rust-guard: dedupe PR/issue response-path setup and add gist/notification path-label tests

[Copilot]

label_response_paths had duplicated PR/issue collection setup logic, creating a divergence risk for repo scope, secrecy defaults, and empty-search handling. It also lacked direct tests for list_gists secrecy branching and list_notifications label semantics in the path-labeling codepath.

• Refactor: shared repo-item collection context

  • Added RepoItemsContext + resolve_repo_item_context(...) in response_paths.rs.
  • Centralized extraction of:
    • items + items_path
    • repo scope fallback from args/query
    • default_repo / default_repo_private
    • default secrecy behavior for non-search vs search tools
    • bounded item iteration (limit_items_with_log)
  • Reused this helper in both PR and issue arms to remove duplicated setup while preserving per-item labeling behavior.

• Coverage: path-label tests for gists and notifications

  • Added targeted unit tests in response_paths.rs for:
    • public gist → empty secrecy
    • private gist → private_user_label()
    • notifications → private-user secrecy + empty integrity

• Code shape / readability

  • Kept per-item PR/issue integrity and description logic unchanged.
  • Added helper-level docs clarifying tool_name vs search_tool_name semantics.

if let Some(repo_item_ctx) = resolve_repo_item_context(
    tool_name,
    tool_args,
    &actual_response,
    "search_pull_requests",
    "list_pull_requests",
    ctx,
) {
    for (i, item) in repo_item_ctx.limited_items.iter().enumerate() {
        // existing per-item PR labeling logic
    }
}

[Copilot]

Pull request overview

This PR refactors the Rust guard’s path-labeling logic to remove duplicated PR/issue response setup and adds unit tests covering previously untested secrecy/integrity behaviors for gists and notifications. This reduces divergence risk in repo-scope/secrecy defaults while improving confidence in response-path labeling for additional GitHub API collection tools.

Changes:

• Introduced RepoItemsContext and resolve_repo_item_context(...) to centralize shared PR/issue collection extraction, repo-scope fallback, default secrecy selection, and bounded iteration.
• Updated PR and issue labeling arms to consume the shared context helper while preserving per-item labeling behavior.
• Added unit tests validating list_gists secrecy branching (public vs private) and list_notifications secrecy/integrity semantics.

Show a summary per file

File	Description
guards/github-guard/rust-guard/src/labels/response_paths.rs	Deduplicates PR/issue response collection setup via a shared helper and adds gist/notification path-label unit tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Low