Model gh codespace stop as a guarded write operation - #8764
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix guard coverage gap for GitHub CLI operation
Model Jul 6, 2026
gh codespace stop as a guarded write operation
lpcox
marked this pull request as ready for review
July 6, 2026 12:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes a GitHub guard classification gap by explicitly modeling gh codespace stop as a write operation in the Rust GitHub guard, ensuring the gateway’s DIFC enforcement treats it as a guarded write.
Changes:
- Added
stop_codespaceto theWRITE_OPERATIONSset used forbinary_search-based write classification. - Extended the existing CLI-coverage regression test to assert
stop_codespaceis recognized as a write operation.
Show a summary per file
| File | Description |
|---|---|
| guards/github-guard/rust-guard/src/tools.rs | Adds stop_codespace to the sorted write-operation list and updates the CLI gap regression test accordingly. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub guard had a CLI-only coverage gap:
gh codespace stopcould reach a write endpoint without a modeled guard entry. This change closes that gap by classifying the operation explicitly in the Rust guard’s write-operation set.What changed
stop_codespacetoWRITE_OPERATIONSinguards/github-guard/rust-guard/src/tools.rsbinary_search-based classificationRegression coverage
stop_codespaceis treated as a write operationExample