fix: add missing WASM compilation cache cleanup in run()#8424
Merged
Conversation
5 tasks
Copilot
AI
changed the title
[WIP] Fix duplicate code pattern in run() and runProxy() methods
fix: add missing WASM compilation cache cleanup in run()
Jul 1, 2026
lpcox
marked this pull request as ready for review
July 1, 2026 15:27
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the gateway’s main run() path properly releases wazero disk-backed WASM compilation cache resources on shutdown, aligning lifecycle management with the existing runProxy() behavior and reducing risk of unflushed transient cache state.
Changes:
- Add
internal/guardimport tointernal/cmd/root.go. - After a successful
configureWasmCompilationCache(...), deferguard.CloseGlobalCompilationCache(context.WithoutCancel(ctx))and log on close failure.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/root.go | Adds deferred shutdown cleanup for the global WASM compilation cache in the main gateway run() path. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run()inroot.goconfigured the wazero disk-backed compilation cache but never calledguard.CloseGlobalCompilationCache()on shutdown, unlikerunProxy()which defers the cleanup correctly. For disk-backed caches this risks leaving transient state unflushed.Changes
internal/cmd/root.go: Addguardimport and deferCloseGlobalCompilationCacheafter a successfulconfigureWasmCompilationCachecall, mirroring the existing pattern inproxy.go: