Skip to content

[log] proxy/handler: add debug logging to forwardAndReadBody and writeEmptyResponse #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Jun 6, 2026
Merged

[log] proxy/handler: add debug logging to forwardAndReadBody and writeEmptyResponse #7066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cf3bf
proxy/handler: add debug logging to forwardAndReadBody and writeEmpty…
github-actions[bot] Jun 5, 2026
2ee1a1e
Potential fix for pull request finding
lpcox Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/proxy/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ func (h *proxyHandler) writeEmptyResponse(w http.ResponseWriter, resp *http.Resp
default:
empty = "[]" // safe default for nil or unknown types
}
logHandler.Printf("writeEmptyResponse: shape=%s, status=%d", empty, resp.StatusCode)
httputil.WriteJSONResponse(w, resp.StatusCode, json.RawMessage(empty))
}

Expand All @@ -378,17 +379,21 @@ func (h *proxyHandler) forwardAndReadBody(
w http.ResponseWriter, ctx context.Context,
method, path string, body io.Reader, contentType, clientAuth string,
) (*http.Response, []byte) {
logHandler.Printf("forwardAndReadBody: %s %s", method, path)
resp, err := h.server.forwardToGitHub(ctx, method, path, body, contentType, clientAuth)
if err != nil {
logHandler.Printf("forwardAndReadBody: upstream request failed: method=%s path=%s err=%v", method, path, err)
httputil.WriteErrorResponse(w, http.StatusBadGateway, "bad_gateway", "upstream request failed")
return nil, nil
}
defer resp.Body.Close()
respBody, err := io.ReadAll(resp.Body)
if err != nil {
logHandler.Printf("forwardAndReadBody: body read failed: method=%s path=%s status=%d err=%v", method, path, resp.StatusCode, err)
httputil.WriteErrorResponse(w, http.StatusBadGateway, "bad_gateway", "failed to read upstream response")
return nil, nil
}
logHandler.Printf("forwardAndReadBody: %s %s -> status=%d bodyLen=%d", method, path, resp.StatusCode, len(respBody))
return resp, respBody
}

Expand Down
Loading