Skip to content

[test-improver] Improve tests for server shutdown #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Apr 30, 2026
Merged

[test-improver] Improve tests for server shutdown #4852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
902526a
Improve tests for server shutdown
github-actions[bot] Apr 30, 2026
cfc8320
Potential fix for pull request finding
lpcox Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions internal/server/shutdown_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,16 @@ func TestShutdownBehavior_RoutedMode(t *testing.T) {
var response map[string]interface{}
err := json.NewDecoder(w.Body).Decode(&response)
require.NoError(t, err, "Failed to decode JSON response")
if errorMsg, ok := response["error"].(string); ok {
assert.Equal(t, tt.expectError, errorMsg, "Unexpected error message")
} else {
t.Errorf("Expected error field in response")
}
require.Contains(t, response, "error", "response should contain an 'error' field")
assert.Equal(t, tt.expectError, response["error"], "Unexpected error message")
}
})
}
}

// TestShutdownBehavior_UnifiedMode tests that MCP endpoints return 503 after /close in unified mode
func TestShutdownBehavior_UnifiedMode(t *testing.T) {
t.Parallel()
tests := []struct {
name string
endpoint string
Expand Down Expand Up @@ -191,11 +189,8 @@ func TestShutdownBehavior_UnifiedMode(t *testing.T) {
var response map[string]interface{}
err := json.NewDecoder(w.Body).Decode(&response)
require.NoError(t, err, "Failed to decode JSON response")
if errorMsg, ok := response["error"].(string); ok {
assert.Equal(t, tt.expectError, errorMsg, "Unexpected error message")
} else {
t.Errorf("Expected error field in response")
}
require.Contains(t, response, "error", "response should contain an 'error' field")
assert.Equal(t, tt.expectError, response["error"], "Unexpected error message")
}
})
}
Expand Down
Loading