[log] Replace standard log calls with logHealth in health_monitor.go - #4772
Merged
Conversation
The health_monitor.go file declared logHealth = logger.New("launcher:health")
but two functions (Start and handleErrorState) still used the standard
library log.Printf instead of the project's structured logger.
- Replace log.Printf("[HEALTH] Starting...") with logHealth.Printf
- Replace log.Printf("[HEALTH] Successfully restarted...") with logHealth.Printf
- Remove now-unused "log" standard library import
This makes logging consistent with the rest of the file and the project's
debug logging conventions described in AGENTS.md.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes health monitor debug logging by replacing remaining log.Printf calls with the project’s structured debug logger (logHealth) and removing the now-unused standard library log import.
Changes:
- Replace
log.Printfusage inStart()withlogHealth.Printf(...). - Replace
log.Printfusage inhandleErrorState()withlogHealth.Printf(...). - Remove unused
logimport fromhealth_monitor.go.
Show a summary per file
| File | Description |
|---|---|
| internal/launcher/health_monitor.go | Switches remaining standard-library logging to logHealth and cleans up the import list. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/launcher/health_monitor.godeclaredlogHealth = logger.New("launcher:health")(the project's structured debug logger) but two functions still used the standard librarylog.Printfinstead:Start()—log.Printf("[HEALTH] Starting health monitor ...")handleErrorState()—log.Printf("[HEALTH] Successfully restarted server %q", serverID)Changes
log.Printf("[HEALTH] Starting...")withlogHealth.Printf("Starting health monitor: interval=%v", ...)log.Printf("[HEALTH] Successfully restarted...")withlogHealth.Printf("Successfully restarted server: serverID=%s", ...)"log"standard library importWhy
Per AGENTS.md, all debug output should go through the project's logger (
logger.New(...)) rather than the standard librarylogpackage. This ensures:DEBUG=launcher:*env varFiles Modified
internal/launcher/health_monitor.go— 1 file, 2 log call replacements, 1 import removedValidation
go build ./...✅go vet ./...✅