Fix duplicate HTTP request/response log statements between sendHTTPRequest and executeHTTPRequest

[Copilot]

sendHTTPRequest and its callee executeHTTPRequest both logged HTTP request dispatch and response receipt, producing 4 log lines per round-trip under DEBUG=mcp:* instead of 2.

Changes

• internal/mcp/http_transport.go: The logConn.Printf calls for "Sending HTTP request" and "Received HTTP response" in sendHTTPRequest are now guarded with !logHTTP.Enabled(), preventing duplicate output when the more-detailed mcp:http_transport logger is active while preserving mcp:connection visibility when it is not:

if !logHTTP.Enabled() {
    logConn.Printf("Sending HTTP request to %s: method=%s, id=%d", c.httpURL, method, requestID)
}
result, err := c.executeHTTPRequest(...)
if !logHTTP.Enabled() {
    logConn.Printf("Received HTTP response: status=%d, body_len=%d", result.StatusCode, len(result.ResponseBody))
}

This means:

• DEBUG=mcp:* — only logHTTP fires (no duplicates)
• DEBUG=mcp:connection — logConn fires as before (single pair per round-trip)
• DEBUG=mcp:http_transport — only logHTTP fires (no duplicates)

[Copilot]

Pull request overview

This PR reduces duplicate HTTP request/response debug logging by removing the “Sending HTTP request …” and “Received HTTP response …” logConn.Printf statements from sendHTTPRequest, relying on executeHTTPRequest’s logging instead.

Changes:

• Removed connection-namespace send/receive log lines from sendHTTPRequest to avoid duplicate per-round-trip logs.
• Left executeHTTPRequest as the single source of “request executing” / “response received” HTTP logs.

Show a summary per file

File	Description
internal/mcp/http_transport.go	Removes duplicate request/response log statements from sendHTTPRequest to reduce log noise.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1

[Copilot]

By removing the request/response logs here, HTTP round-trip visibility now depends entirely on the mcp:http_transport logger (i.e., DEBUG=mcp:connection will no longer show any per-request send/receive lines). If the intent is only to remove duplicates under DEBUG=mcp:* while preserving the existing mcp:connection behavior, consider emitting the logConn lines conditionally (e.g., only when !logHTTP.Enabled()), or otherwise ensuring the connection-level logger still provides a single request/response pair.

[lpcox]

@copilot address this review feedback #4606 (review)

[Copilot]

@copilot address this review feedback #4606 (review)

Addressed in 6b00f8f. The logConn send/receive lines are now guarded with !logHTTP.Enabled():

• DEBUG=mcp:* → only logHTTP fires (no duplicates)
• DEBUG=mcp:connection → logConn fires as before (single pair per round-trip)
• DEBUG=mcp:http_transport → only logHTTP fires

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• example.com
  • Triggering command: /tmp/go-build629936415/b509/launcher.test /tmp/go-build629936415/b509/launcher.test -test.testlogfile=/tmp/go-build629936415/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true aw-mcpg/internal-p cfg x_amd64/compile (dns block)
• invalid-host-that-does-not-exist-12345.com
  • Triggering command: /tmp/go-build629936415/b491/config.test /tmp/go-build629936415/b491/config.test -test.testlogfile=/tmp/go-build629936415/b491/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-p 6UTz/5ecS_4XL9_qgoogle.golang.org/grpc/internal x_amd64/compile (dns block)
• nonexistent.local
  • Triggering command: /tmp/go-build629936415/b509/launcher.test /tmp/go-build629936415/b509/launcher.test -test.testlogfile=/tmp/go-build629936415/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true aw-mcpg/internal-p cfg x_amd64/compile (dns block)
• slow.example.com
  • Triggering command: /tmp/go-build629936415/b509/launcher.test /tmp/go-build629936415/b509/launcher.test -test.testlogfile=/tmp/go-build629936415/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true aw-mcpg/internal-p cfg x_amd64/compile (dns block)
• this-host-does-not-exist-12345.com
  • Triggering command: /tmp/go-build629936415/b518/mcp.test /tmp/go-build629936415/b518/mcp.test -test.testlogfile=/tmp/go-build629936415/b518/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true se cfg ache/go/1.25.9/x-nilfunc -p go.opentelemetry-atomic -lang=go1.25 ache/go/1.25.9/x-buildtags (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)