-
Notifications
You must be signed in to change notification settings - Fork 30
feat: GHEC tenant support for proxy and guard URL parsing #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1b04f55
feat: GHEC tenant support for proxy and guard URL parsing
lpcox 880c1d9
fix: use copilot-api prefix for GHEC tenant URL derivation
Copilot aafd8a4
Update internal/proxy/proxy_test.go
lpcox 78a1bf6
Initial plan
Copilot 10cc9d3
fix: use parsed.Hostname() in deriveAPIFromServerURL for port-safe GH…
Copilot 909ff10
fix: port-safe GHEC detection in deriveAPIFromServerURL (#2484)
lpcox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the GHES case this derives the upstream base as /api/v3. Elsewhere the proxy forwards GraphQL requests to a hard-coded "/graphql" path; with an /api/v3 base this becomes /api/v3/graphql, but GHES GraphQL is typically served under /api/graphql (and the proxy already recognizes "/api/graphql" as a GraphQL path). To avoid GHES GraphQL requests breaking when using the auto-derived URL, consider either (a) keeping the base at the host root and adding /api/v3 only for REST requests, or (b) making the forwarded GraphQL path configurable/derived separately (e.g., /graphql for github.com/GHEC vs /api/graphql for GHES).