[duplicate-code] Duplicate Code Analysis Report

[github-actions]

🔍 Duplicate Code Analysis Report

Analysis of commit dd09d70

Summary

Semantic code analysis of the Go codebase identified 3 significant duplication patterns affecting maintainability. Patterns span critical packages: internal/mcp, internal/cmd, and internal/config/rules.

Detected Patterns

1. MCP Connection Reconnect Boilerplate — Severity: Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: MCP Connection Reconnect Boilerplate #7079
2. HTTP Server Lifecycle (Serve/Wait/Shutdown) — Severity: Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: HTTP Server Lifecycle in cmd/root.go and cmd/proxy.go #7080
3. TimeoutPositive vs PositiveInteger Overlapping Validators — Severity: Low–Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: TimeoutPositive and PositiveInteger Overlapping Validators #7081

Overall Impact

• Total Duplicated Lines: ~45 lines across 5 files
• Affected Files: internal/mcp/connection.go, internal/cmd/root.go, internal/cmd/proxy.go, internal/config/rules/rules.go
• Maintainability Risk: Medium — bugs fixed in one copy may not be fixed in the other
• Refactoring Priority: Medium — patterns are well-isolated and extractable with low risk

Next Steps

1. Review individual pattern sub-issues for detailed analysis
2. Prioritize refactoring the two Medium-severity patterns first
3. The validator overlap can be addressed opportunistically

Analysis Metadata

• Analyzed Files: 100+ non-test Go files in internal/
• Detection Method: Semantic code analysis (pattern search + symbol overview + file content review)
• Commit: dd09d70a92f2d3897b77cc8418ca1ba33e87249e
• Analysis Date: 2026-06-06T03:41:31Z
• Triggered by: @lpcox