fix: add mode: gh-proxy to smoke-sink-visibility workflows#6164
Merged
Conversation
The gh CLI was unauthenticated inside the AWF container because the default local mode doesn't set up the CLI proxy (DIFC proxy sidecar). Adding mode: gh-proxy tells the compiler to configure the cli-proxy container so gh CLI calls are authenticated through the MCPG proxy. Lock files need recompilation with the newer compiler that supports private-to-public-flows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitHub CLI proxy mode to both sink-visibility smoke workflows.
Changes:
- Enables
mode: gh-proxyfor allowed and blocked scenarios. - Corresponding generated lock workflows remain stale.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/smoke-sink-visibility-allowed.md |
Enables GitHub CLI proxy mode. |
.github/workflows/smoke-sink-visibility-blocked.md |
Enables GitHub CLI proxy mode. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Medium
| bash: | ||
| - "*" | ||
| github: | ||
| mode: gh-proxy |
| bash: | ||
| - "*" | ||
| github: | ||
| mode: gh-proxy |
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This should make the MCP Gateway (and CLI proxy) deny reads from private repos, which is needed for the sink-visibility-blocked smoke test to actually block access to github/agentic-workflows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
The CLI proxy guard policy had repos='all' which allows reading any repo including private ones. Change to repos='public' so the MCPG CLI proxy filters out private repos like github/agentic-workflows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both smoke-sink-visibility workflows (allowed and blocked) failed because the
ghCLI was unauthenticated inside the AWF agent container.Root cause: Without
mode: gh-proxy, the defaultlocalmode is used. In local mode the gh-aw compiler doesn't set up the CLI proxy (DIFC proxy sidecar), so:GITHUB_TOKEN/GH_TOKENare cleared by AWF's one-shot token isolationghCLI callsFix
Add
mode: gh-proxytotools.githubin both workflow.mdfiles. This tells the compiler to:cli-proxycontainer to the AWF topology--difc-proxy-host awmg-cli-proxy:18443to AWFghCLI through the MCPG CLI proxyNext steps
Lock files need recompilation on this branch (the local compiler
v0.82.8doesn't supportprivate-to-public-flows— the lock files were originally compiled withv0.82.8-28+).