Update Runner Doctor A15 status to reflect merged ARC/DinD permission-repair fix#5971
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Runner Doctor failure-mode catalog to reflect that ARC/DinD A15 is no longer an open issue, aligning diagnoses and citations with the merged remediation in github/gh-aw-firewall#5963.
Changes:
- Mark A15 as fixed (with updated remediation text) and expand citations to include the original report, tracking PR, and merged fix.
- Remove A15 from the “Known unresolved items” section in the mirrored runner-doctor catalogs.
- Update the runner-doctor alignment test to validate the new fixed wording and ensure the unresolved-items entry is gone.
Show a summary per file
| File | Description |
|---|---|
| scripts/ci/self-hosted-runner-doctor-workflow.test.ts | Updates the alignment guard assertions for A15’s new “fixed” wording and removal from unresolved items. |
| .github/workflows/shared/self-hosted-failure-modes.md | Updates A15 status/remediation text and removes A15 from the unresolved-items list. |
| .github/agents/self-hosted-runner-doctor.md | Mirrors the same A15 status/remediation and unresolved-items cleanup for the portable agent catalog. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
| expect(content).toContain('**Fixed in PR github/gh-aw-firewall#5963**: `fixArtifactPermissionsForRootless()` now calls `applyHostPathPrefixToVolumes()` so the repair container bind mount is correctly translated for the DinD daemon. Upgrade AWF to the version that includes github/gh-aw-firewall#5963. Workaround (older AWF): run `chmod -R a+rX` inside the squid container before `docker compose down`.'); | ||
| expect(content).toContain('github/gh-aw-firewall#5816, github/gh-aw-firewall#5817, github/gh-aw-firewall#5963'); | ||
| expect(content).toContain('| `unknown shorthand flag: \'d\' in -d` from `docker compose up -d` on ARC/DinD | A14 |'); | ||
| expect(content).toContain('| `Rootless artifact permission repair failed for .../sandbox/firewall/logs` on ARC/DinD | A15 |'); | ||
| expect(content).toContain('- A15 / github/gh-aw-firewall#5816 — rootless artifact permission repair on ARC/DinD: `fixArtifactPermissionsForRootless()` does not apply `dockerHostPathPrefix` to repair step bind mount; fix tracked in PR github/gh-aw-firewall#5817'); | ||
| expect(content).not.toContain('- A15 / github/gh-aw-firewall#5816 — rootless artifact permission repair on ARC/DinD: `fixArtifactPermissionsForRootless()` does not apply `dockerHostPathPrefix` to repair step bind mount; fix tracked in PR github/gh-aw-firewall#5817'); |
|
@copilot address review feedback |
Addressed in f37b451. I updated |
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
✅ Smoke Claude passed |
|
🔌 Smoke Services — All services reachable! ✅ |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
Chroot tests failed Smoke Chroot failed - See logs for details. |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Build Test Suite completed successfully! |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
✅ Contribution Check completed successfully! PR follows the applicable contribution guidelines; no review comment needed. |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
| Metric | Base | PR | Delta |
|---|---|---|---|
| Lines | 98.82% | 98.82% | ➡️ +0.00% |
| Statements | 98.76% | 98.76% | ➡️ +0.00% |
| Functions | 99.72% | 99.72% | ➡️ +0.00% |
| Branches | 95.19% | 95.15% | 📉 -0.04% |
Coverage comparison generated by scripts/ci/compare-coverage.ts
Smoke Test: Claude Engine Validation
Overall Result: PASS ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test Results
Overall: FAIL — Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: PAT Auth
Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🔬 Smoke Test Results
Overall: PASS (MCP verified)
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing
All scenarios pass. OTEL tracing integration is functional. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Copilot BYOK (Direct) — PR #5971
Running in direct BYOK mode ( cc Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test Results
PR Titles Reviewed:
Overall status: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test
Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"
- "registry.npmjs.org"See Network Configuration for more information.
|
The Runner Doctor knowledge base still described A15 as an open ARC/DinD failure even though PR #5963 merged the underlying fix. This updates the catalog so diagnoses point users to the shipped remediation instead of an in-progress workaround.
Catalog status update
github/gh-aw-firewall#5963fixArtifactPermissionsForRootless()now appliesapplyHostPathPrefixToVolumes()for the repair bind mountchmod -R a+rXguidance as a workaround for pre-fix AWF versionsCitations
github/gh-aw-firewall#5816github/gh-aw-firewall#5817github/gh-aw-firewall#5963Unresolved-items cleanup
Mirrored runner-doctor sources
.github/workflows/shared/self-hosted-failure-modes.md.github/agents/self-hosted-runner-doctor.mdAlignment guard