Fix split-fs test to use actual effectiveHome instead of hardcoded /home by lpcox · Pull Request #5781 · github/gh-aw-firewall

lpcox · 2026-07-01T20:22:24Z

Problem

The compose-generator test "filters out workDir and home dot-directory bind mounts on split-fs" was failing on macOS because it hardcoded /host/home as the prefix for filtering home-target volumes. This only works on Linux where home directories are under /home/.

On macOS (home under /Users/), the filter matched nothing, so the homeTargets array was empty and the workspace mount assertion failed:

Expected value: "/host/Users/lpcox/projects/gh-aw-firewall"
Received array: []

Fix

Use getRealUserHome() to derive the actual home prefix dynamically, making the test portable across platforms (Linux /home/runner and macOS /Users/...).

Testing

All 3387 tests pass locally on macOS

The compose-generator test 'filters out workDir and home dot-directory bind mounts on split-fs' hardcoded '/host/home' as the prefix for filtering home-target volumes. This only works on Linux where home directories are under /home/. On macOS (home under /Users/), the filter matched nothing, causing the workspace mount assertion to fail. Use getRealUserHome() to derive the actual home prefix, making the test portable across platforms. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes a platform-specific unit test failure in generateDockerCompose’s split-filesystem (“split-fs” / arc-dind) coverage by removing a Linux-specific assumption about home directory paths. The test now derives the effective home directory dynamically so it works on macOS (/Users/...) as well as Linux (/home/...).

Changes:

Update the split-fs compose-generator test to filter home-target bind mounts using getRealUserHome() instead of a hardcoded /home-based prefix.
Adjust the “home dot-directory mounts should be dropped” assertion to use the derived home path.

Show a summary per file

File	Description
`src/compose-generator.test.ts`	Makes the split-fs volume filtering logic in the test use the actual effective home directory, improving cross-platform portability.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Low

github-actions · 2026-07-01T20:24:22Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.64%	98.68%	📈 +0.04%
Statements	98.53%	98.56%	📈 +0.03%
Functions	99.56%	99.56%	➡️ +0.00%
Branches	94.51%	94.51%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	93.0% → 94.8% (+1.74%)	93.0% → 94.8% (+1.74%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-01T20:32:42Z

✅ Smoke Claude passed

github-actions · 2026-07-01T20:32:44Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-07-01T20:32:49Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke test completed with partial failures. Results reported to PR #5781.

github-actions · 2026-07-01T20:32:50Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-01T20:32:52Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-01T20:32:52Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-01T20:32:56Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-07-01T20:32:59Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-01T20:33:01Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-07-01T20:33:02Z

✅ Contribution Check completed successfully!

Contribution guidelines review complete for PR #5781: no important missing items found; the PR follows applicable CONTRIBUTING.md guidance.

github-actions · 2026-07-01T20:33:06Z

🔌 Smoke Services — Service connectivity failed ⚠️

github-actions · 2026-07-01T20:33:14Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-01T20:33:26Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-07-01T20:33:43Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-07-01T20:35:48Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
GH check	✅ PASS
File status	✅ PASS

Overall result: PASS ✅

Generated by Smoke Claude for #5781 · 52.3 AIC · ⊞ 3.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:35:52Z

🔥 Smoke Test: Copilot PAT — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP connectivity	✅
File write/read	✅

PR: Fix split-fs test to use actual effectiveHome instead of hardcoded /home
Author: @lpcox
Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Overall: PASS

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:36:26Z

🔬 Smoke Test Results

PR: Fix split-fs test to use actual effectiveHome instead of hardcoded /home
Author: @lpcox

Test	Result
GitHub MCP connectivity	✅ PASS
GitHub.com HTTP connectivity	❌ Data unavailable (template not substituted)
File write/read	❌ Data unavailable (template not substituted)

Overall: FAIL — pre-computed smoke data (steps.smoke-data.outputs.*) was not substituted into the agent prompt.

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:36:29Z

Smoke Test: Copilot BYOK (Direct) Mode

Test	Result
GitHub MCP	✅
github.com HTTP	✅
File I/O	✅
BYOK Inference	✅

Status: PASS
Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY) → api-proxy → api.githubcopilot.com

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:37:06Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.17.0	v22.23.0	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:37:08Z

Smoke test summary

fix: ensure chmod runs even when chown fails in rootless permission repair: ✅
refactor: split 309-line generateDockerCompose into focused phases: ✅
GitHub reads: ✅
Playwright GitHub title: ✅
File write/read: ✅
Build (npm ci && npm run build): ✅
Discussion comment: ❌ unavailable in this workflow
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:37:10Z

Smoke Test Results

GitHub MCP Testing: ❌ (Tools not found)
GitHub.com Connectivity: ❌ (SSL Error 35)
File Writing Testing: ✅
Bash Tool Testing: ✅

PR Titles:

fix: sysroot filter should not drop workspace custom mounts (fix: sysroot filter should not drop workspace custom mounts #5739)

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:37:25Z

@lpcox Smoke Test Results:
PRs: Fix split-fs test to use actual effectiveHome instead of hardcoded /home; chore: upgrade gh-aw to v0.82.1 pre-release and recompile workflows: ✅
GitHub.com HTTP: ✅
File I/O: ✅
BYOK inference: ✅
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:37:27Z

@lpcox

MCP test: ✅
GitHub.com connectivity: ✅
File write/read: ✅
BYOK inference: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:38:30Z

🔍 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Details
1. Module Loading	✅ Pass	`otel.js` loads cleanly; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled` (+ test internals)
2. Test Suite	✅ Pass	59 tests passed, 0 failed across `otel.test.js` and `otel-fanout.test.js`
3. Env Var Forwarding	✅ Pass	`api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME` to the sidecar
4. Token Tracker Integration	✅ Pass	`onUsage` callback present in `token-tracker-http.js` (`finalizeHttpTracking`, line 283); `onSpanEnd` hook also wired for span completion
5. OTEL Diagnostics	✅ Pass (graceful degradation)	No OTLP endpoint configured → falls back to `FileSpanExporter` at `/var/log/api-proxy/otel.jsonl`; no errors on unconfigured startup

All 5 scenarios pass. The OTEL tracing integration is fully implemented and all tests are green.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T20:39:06Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for #5781 · 40.1 AIC · ⊞ 7.8K · ◷
_{Add label ready-for-aw to run again}

Copilot AI review requested due to automatic review settings July 1, 2026 20:22

Copilot started reviewing on behalf of lpcox July 1, 2026 20:22 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

lpcox added the ready-for-aw label Jul 1, 2026

lpcox temporarily deployed to aoai-model July 1, 2026 20:33 — with GitHub Actions Inactive

github-actions Bot added the smoke-claude label Jul 1, 2026

github-actions Bot added the smoke-copilot-pat label Jul 1, 2026

github-actions Bot added the smoke-copilot-byok label Jul 1, 2026

github-actions Bot mentioned this pull request Jul 1, 2026

[aw] No-Op Runs #5368

Closed

lpcox temporarily deployed to aoai-model July 1, 2026 20:37 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jul 1, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 1, 2026

lpcox temporarily deployed to aoai-model July 1, 2026 20:37 — with GitHub Actions Inactive

github-actions Bot added the build-test label Jul 1, 2026

lpcox merged commit 029e317 into main Jul 1, 2026
87 of 89 checks passed

lpcox deleted the fix-split-fs-test-macos branch July 1, 2026 20:54

github-actions Bot mentioned this pull request Jul 1, 2026

fix: detect and expose system CA bundle for RHEL/Amazon Linux in chroot #5783

Merged

Uh oh!

Conversation

lpcox commented Jul 1, 2026

Problem

Fix

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 1, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 1, 2026

🔥 Smoke Test: Copilot PAT — PASS

Uh oh!

github-actions Bot commented Jul 1, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 1, 2026

Smoke Test: Copilot BYOK (Direct) Mode

Uh oh!

github-actions Bot commented Jul 1, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading