Skip to content

Sync Copilot model allowlist with model API mapping#5756

Merged
lpcox merged 4 commits into
mainfrom
copilot/update-supported-copilot-models
Jul 1, 2026
Merged

Sync Copilot model allowlist with model API mapping#5756
lpcox merged 4 commits into
mainfrom
copilot/update-supported-copilot-models

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Host-side Copilot model validation had drifted from docs/model-api-mapping.json, causing valid models like claude-sonnet-5 to be rejected before AWF started. The failure message also mislabeled missing allowlist entries as “retired”, even when they were not in the retired-alias map.

  • Allowlist sync

    • Add newly documented model families to SUPPORTED_COPILOT_MODELS in src/copilot-model.ts:
      • gpt-4.5
      • gpt-5.1
      • claude-fable-5
      • claude-mythos-5
      • claude-sonnet-5
  • Error semantics

    • Keep true retired-model handling unchanged.
    • Change the generic unsupported path to say the model is unsupported or unrecognized by this AWF version, instead of implying retirement.
  • Coverage

    • Extend src/copilot-model.test.ts to assert the new models are accepted.
    • Update unsupported-model assertions to match the clarified error wording.
const result = validateCopilotModel('claude-sonnet-5');
// before: invalid, suggested claude-sonnet-4.5
// after:
expect(result).toEqual({ valid: true, resolvedModel: 'claude-sonnet-5' });

Copilot AI changed the title [WIP] Update SUPPORTED_COPILOT_MODELS to include valid models Sync Copilot model allowlist with model API mapping Jul 1, 2026
Copilot AI requested a review from lpcox July 1, 2026 18:37
Copilot finished work on behalf of lpcox July 1, 2026 18:37
@lpcox lpcox requested a review from Copilot July 1, 2026 18:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates host-side Copilot model validation so AWF accepts additional model identifiers and clarifies the “unsupported model” error message, with corresponding Jest test updates.

Changes:

  • Expanded SUPPORTED_COPILOT_MODELS in src/copilot-model.ts to accept additional model IDs.
  • Updated the generic unsupported-model error wording to avoid implying “retirement” when a model is simply unknown to this AWF version.
  • Extended src/copilot-model.test.ts to cover the new accepted models and the updated error wording.
Show a summary per file
File Description
src/copilot-model.ts Adds models to the allowlist and adjusts the unsupported-model error message.
src/copilot-model.test.ts Adds coverage for the new allowlisted models and updates assertions for the new error wording.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 3
  • Review effort level: Low

Comment thread src/copilot-model.ts
Comment on lines 30 to +34
'gpt-4.1',
'gpt-4.5',
'gpt-4o',
'gpt-4o-mini',
'gpt-5.1',
Comment thread src/copilot-model.ts
Comment on lines +44 to +48
'claude-fable-5',
'claude-haiku-4.5',
'claude-mythos-5',
'claude-opus-4.8',
'claude-sonnet-5',
Comment thread src/copilot-model.test.ts Outdated
'claude-fable-5',
'claude-mythos-5',
'claude-sonnet-5',
])('accepts additional mapped canonical models (%s)', model => {
@lpcox

lpcox commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@copilot address review feedback

@lpcox lpcox marked this pull request as ready for review July 1, 2026 19:17

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot address review feedback

Addressed all three review points in be4e978:

  • Added gpt-4.5 and gpt-5.1 to both docs/model-api-mapping.json and containers/api-proxy/model-api-mapping.json
  • Added claude-mythos-5 and claude-sonnet-5 to the same mapping files under the Anthropic section
  • Renamed the test description from "accepts additional mapped canonical models" to "accepts newly supported Copilot allowlist models" to avoid implying mapping-file coverage

Copilot finished work on behalf of lpcox July 1, 2026 19:20
@lpcox

lpcox commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in aa5a652. The conflicts were in both docs/model-api-mapping.json and containers/api-proxy/model-api-mapping.json — main had added those same model families in #5742 with more accurate details (correct endpoint lists, richer notes, additional patterns like claude-mythos-preview*). I accepted main's versions for those files. The copilot-model.ts and copilot-model.test.ts changes from this PR had no conflicts and are fully preserved.

Copilot finished work on behalf of lpcox July 1, 2026 19:40
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Claude passed

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Gemini completed. All facets verified. 💎

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.65% 98.67% 📈 +0.02%
Statements 98.53% 98.55% 📈 +0.02%
Functions 99.55% 99.55% ➡️ +0.00%
Branches 94.46% 94.47% 📈 +0.01%
📁 Per-file Coverage Changes (2 files)
File Lines (Before → After) Statements (Before → After)
src/container-lifecycle.ts 100.0% → 99.1% (-0.91%) 100.0% → 99.1% (-0.87%)
src/workdir-setup.ts 92.7% → 94.5% (+1.82%) 92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Test: Claude Engine Validation

Check Result
API Status ✅ PASS
GH Check ✅ PASS
File Status ✅ PASS

Overall Result: PASS

Generated by Smoke Claude for #5756 · 30.2 AIC · ⊞ 6.1K ·
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Direct Mode) ✅ PASS

Tests:

  • ✅ GitHub MCP: 2 closed PRs listed
  • ✅ GitHub.com: HTTP 200
  • ✅ File I/O: Write/read verified
  • ✅ BYOK Inference: Direct mode active (api-proxy → api.githubcopilot.com)

All tests passed. Running in direct BYOK mode with COPILOT_PROVIDER_API_KEY.

/cc @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🤖 Smoke Test Results

Test Status
GitHub MCP connectivity
GitHub.com connectivity
File write/read

PR: Sync Copilot model allowlist with model API mapping
Author: @Copilot | Assignees: @lpcox @Copilot

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot PAT — PASS

Test Result
GitHub MCP connectivity
GitHub.com HTTP
File write/read

PR: Sync Copilot model allowlist with model API mapping
Auth mode: PAT (COPILOT_GITHUB_TOKEN)
cc @Copilot @lpcox

🔑 PAT report filed by Smoke Copilot PAT
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario Result Notes
1. Module Loading otel.js loads; exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled
2. Test Suite 59/59 tests pass across 2 suites (otel.test.js, otel-fanout.test.js)
3. Env Var Forwarding api-proxy-env-config.ts forwards GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME
4. Token Tracker Integration onUsage callback exists in token-tracker-http.js (line 283/324) as the OTEL hook point
5. OTEL Diagnostics No endpoint configured → graceful degradation; file fallback writes to /var/log/api-proxy/otel.jsonl

All scenarios pass. OTEL tracing integration is functional.

📡 OTel tracing validated by Smoke OTel Tracing
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

fix: ensure chmod runs even when chown fails in rootless permission repair ✅\nDeduplicate writeConfigs Jest dependency mock registration across config-writer suites ✅\nGitHub title check ✅\nSafe inputs GH query ✅\nDiscussion lookup ✅\nSmoke file write ✅\nBuild ✅\nOverall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
Add label ready-for-aw to run again

@github-actions github-actions Bot mentioned this pull request Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@lpcox @Copilot
Smoke Test Results:

  • refactor: split 309-line generateDockerCompose into focused phases: ✅
  • docs: update runner doctor — A13 fixed in v0.27.15, B7 rootless repair incomplete: ✅
  • GitHub MCP list PRs: ✅
  • GitHub.com connectivity: ✅
  • File I/O sandbox: ✅
  • Direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw): ✅

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@lpcox
✅ GitHub MCP Testing (pre-fetched)
✅ GitHub.com Connectivity
✅ File Write/Read Test
✅ BYOK Inference Test

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3
Node.js v24.17.0 v22.23.0
Go go1.22.12 go1.22.12

Overall: ❌ Not all tests passed

Go versions match, but Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): Maven's local repository directory (~/.m2/repository) could not be created due to root ownership of ~/.m2/. Tests were re-run with -Dmaven.repo.local=/tmp/gh-aw/agent/m2-repo and both projects compiled and passed successfully.

Generated by Build Test Suite for #5756 · 38.1 AIC · ⊞ 7.8K ·
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results: ❌ FAIL

Check Result
Redis PING ❌ timeout (no response on host.docker.internal:6379)
PostgreSQL pg_isready ❌ no response on host.docker.internal:5432
PostgreSQL SELECT 1 ❌ timeout

host.docker.internal resolves to 172.17.0.1 but both ports are unreachable — services appear not to be running or not exposed to this runner.

🔌 Service connectivity validated by Smoke Services
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
Add label ready-for-aw to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment