[Test Coverage] container-lifecycle missing branch coverage by github-actions[bot] · Pull Request #5743 · github/gh-aw-firewall

github-actions · 2026-07-01T09:23:35Z

Adds 9 new Jest tests in src/container-lifecycle-missing-branches.test.ts targeting branches in container-lifecycle.ts that were not exercised by the existing container-start.test.ts and run-agent-command.test.ts suites.

What's covered

Branch	Location	Description
Custom stop timeout	`fastKillAgentContainer`	Verifies the timeout argument is forwarded to `docker stop -t` and the hard-deadline is `(N+5)*1000 ms`
Docker stop error swallowed	`fastKillAgentContainer`	Confirms best-effort semantics: a rejected docker stop does not propagate
`exitCode \|\| 143` normalisation	`runAgentCommand`	Externally-killed agent whose `docker wait` returns `0` must exit with `143`, not `0`
Compose-down cleanup throws before retry	`startContainers`	The `catch (cleanupError)` block is hit when `runComposeDown` rejects; retry still proceeds
CLI-proxy failure during retry	`startContainers`	After an api-proxy/squid first-attempt failure triggers the one-shot retry, a cli-proxy failure on retry surfaces the specific fail-fast error rather than falling through to Squid diagnostics

Test results

PASS src/container-lifecycle-missing-branches.test.ts
  fastKillAgentContainer – stop timeout
    ✓ passes the default 3-second grace period to docker stop
    ✓ passes a custom stop timeout to docker stop
    ✓ encodes the hard deadline as (stopTimeoutSeconds + 5) * 1000 ms
  fastKillAgentContainer – docker stop failure is swallowed
    ✓ resolves without throwing when docker stop rejects
    ✓ still marks the agent as externally killed even if docker stop fails
  runAgentCommand – externally killed, docker wait returns 0
    ✓ normalises exit code to 143 when the killed container exits with 0
  startContainers – retry cleanup failure is handled gracefully
    ✓ proceeds with retry even when compose-down cleanup throws
  startContainers – cli-proxy fails during the one-shot retry
    ✓ throws the specific cli-proxy error when cli-proxy fails on retry
    ✓ does not retry a second time after the cli-proxy retry failure

Tests: 9 passed, 9 total

Generated by Test Coverage Improver · 105.5 AIC · ⊞ 5.9K · ◷

Cover uncovered branches in container-lifecycle.ts: - fastKillAgentContainer: custom stop timeout propagated to docker stop - fastKillAgentContainer: docker stop errors are swallowed (best-effort) - runAgentCommand: externally-killed agent with docker wait returning 0 exercises the `exitCode || 143` normalisation branch - startContainers: compose-down cleanup throws before retry; catch block swallows the error and proceeds with the retry successfully - startContainers: cli-proxy fails during the one-shot retry (triggered by an api-proxy/squid first-attempt failure); the specific cli-proxy error message is surfaced rather than falling through to Squid diagnostics Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR adds a new Jest test suite to exercise previously uncovered branches in src/container-lifecycle.ts, specifically around retry/cleanup behavior, externally-killed agent exit-code normalization, and docker stop timeout propagation.

Changes:

Added 9 branch-coverage tests for fastKillAgentContainer, runAgentCommand, and startContainers.
Validates stop-timeout forwarding and hard-deadline computation for docker stop -t.
Adds retry-path tests for compose-down cleanup failures and cli-proxy failure surfacing.

Show a summary per file

File	Description
`src/container-lifecycle-missing-branches.test.ts`	New Jest tests targeting uncovered branches in `container-lifecycle.ts` retry/cleanup and externally-killed behavior.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Low

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-07-01T18:52:02Z

✅ Copilot review passed with no inline comments.

@github-actions[bot] Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-07-01T18:52:21Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-07-01T18:52:26Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-07-01T18:52:27Z

✅ Contribution Check completed successfully!

Contribution check complete for PR #5743: the PR follows the applicable CONTRIBUTING.md guidelines, so no comment is needed.

github-actions · 2026-07-01T18:52:28Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-07-01T18:52:28Z

✅ Smoke Claude passed

github-actions · 2026-07-01T18:52:33Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-01T18:52:34Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-01T18:52:34Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-01T18:52:35Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-07-01T18:52:40Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-01T18:52:42Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-07-01T18:52:43Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-07-01T18:52:50Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-07-01T18:52:59Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-01T18:54:02Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	98.65%	98.68%	📈 +0.03%
Statements	98.53%	98.57%	📈 +0.04%
Functions	99.55%	99.55%	➡️ +0.00%
Branches	94.48%	94.46%	📉 -0.02%

📁 Per-file Coverage Changes (2 files)

File	Lines (Before → After)	Statements (Before → After)
`src/compose-generator.ts`	99.0% → 99.1% (+0.03%)	97.2% → 97.3% (+0.08%)
`src/workdir-setup.ts`	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-01T18:55:51Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
gh check	✅ PASS
File status	✅ PASS

Overall result: PASS ✅

Generated by Smoke Claude for #5743 · 52.3 AIC · ⊞ 3.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:56:10Z

🔥 Smoke Test Results

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP connectivity	✅ 200
File write/read	⚠️ pre-step data unavailable

PR: [Test Coverage] container-lifecycle missing branch coverage
Author: @github-actions[bot] · No assignees

Overall: PASS ✅

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:56:19Z

🔬 Smoke Test: Copilot PAT Auth — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅

Overall: PASS · Auth mode: PAT (COPILOT_GITHUB_TOKEN)

PR by @github-actions[bot]

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:56:24Z

🔍 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Status	Details
1. Module Loading	✅	`otel.js` loads successfully; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled` + internal test helpers. `isEnabled()` returns `true` (file-fallback mode).
2. Test Suite	✅	59 tests passed, 0 failed across 2 suites (`otel.test.js`, `otel-fanout.test.js`). Covers span creation, token attributes (GenAI conventions), error status, serialization, and exporter variants.
3. Env Var Forwarding	✅	`src/services/api-proxy-env-config.ts` forwards all required vars: `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`.
4. Token Tracker Integration	✅	`token-tracker-http.js` has `onUsage` callback wired at line 283 (parameter) and invoked at line 324 — confirmed OTEL hook point is present.
5. OTEL Diagnostics	⏭️	No live api-proxy container ran in this workflow context. When no OTLP endpoint is configured, spans fall back to `/var/log/api-proxy/otel.jsonl` (expected behavior per module docs).

Overall: ✅ All validatable scenarios pass. Scenario 5 is expected-pending (requires a live run with --enable-api-proxy).

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:56:48Z

🧪 Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`3.12.13`	`3.12.3`	❌
Node.js	`v24.17.0`	`v22.23.0`	❌
Go	`go1.22.12`	`go1.22.12`	✅

Overall: ❌ Tests did not pass — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:56:55Z

@github-actions[bot]
MCP connectivity: ✅
GitHub.com connectivity: ✅
File write/read: ✅
BYOK inference: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall status: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:57:33Z

Smoke Test: Copilot BYOK (Direct) Mode

✅ GitHub MCP connectivity
✅ GitHub.com HTTP 200
✅ File I/O operations
✅ BYOK inference path (api-proxy → api.githubcopilot.com)

Status: PASS
Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY)
Route: Agent → api-proxy sidecar → api.githubcopilot.com

CC: @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:57:59Z

PASS

fix: sysroot filter should not drop workspace custom mounts
fix: filter split-fs-invisible mounts when sysroot-stage is active (arc-dind)
GitHub title check: ✅
File write: ✅
Build: ✅
Overall status: PASS

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:58:16Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for #5743 · 59 AIC · ⊞ 7.8K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:58:40Z

Smoke Test: Gemini Engine Validation

GitHub MCP Testing: ✅ (PRs fix: sysroot filter should not drop workspace custom mounts #5739, fix: filter split-fs-invisible mounts when sysroot-stage is active (arc-dind) #5734)
GitHub.com Connectivity: ✅ (Status 200)
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: PASS

Last 2 merged PRs:

fix: sysroot filter should not drop workspace custom mounts
fix: filter split-fs-invisible mounts when sysroot-stage is active (arc-dind)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T18:58:47Z

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis PING	❌ Timeout
PostgreSQL pg_isready	❌ No response
PostgreSQL SELECT 1	❌ Timeout

Overall: FAIL — host.docker.internal is not reachable from this runner. Service containers appear unavailable.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-01T19:00:47Z

@github-actions[bot]
MCP connectivity (merged PRs: fix: ensure chmod runs even when chown fails in rootless permission repair, refactor: split 309-line generateDockerCompose into focused phases): ✅
GitHub.com HTTP connectivity: ✅
File write/read test: ✅
Direct BYOK inference: ✅
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

lpcox marked this pull request as ready for review July 1, 2026 18:28

Copilot AI review requested due to automatic review settings July 1, 2026 18:28

Copilot started reviewing on behalf of lpcox July 1, 2026 18:29 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread src/container-lifecycle-missing-branches.test.ts

Potential fix for pull request finding

9a884ce

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

lpcox added the ready-for-aw label Jul 1, 2026

lpcox temporarily deployed to aoai-model July 1, 2026 18:52 — with GitHub Actions Inactive

github-actions Bot added the smoke-claude label Jul 1, 2026

github-actions Bot mentioned this pull request Jul 1, 2026

[aw] No-Op Runs #5368

Closed

github-actions Bot added the smoke-copilot label Jul 1, 2026

lpcox temporarily deployed to aoai-model July 1, 2026 18:56 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-pat label Jul 1, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 1, 2026

lpcox temporarily deployed to aoai-model July 1, 2026 18:57 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok label Jul 1, 2026

github-actions Bot added the smoke-codex label Jul 1, 2026

github-actions Bot added the build-test label Jul 1, 2026

github-actions Bot added the smoke-gemini label Jul 1, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jul 1, 2026

lpcox merged commit 0fe10ef into main Jul 1, 2026
85 of 88 checks passed

lpcox deleted the test-coverage/container-lifecycle-missing-branches-127fca4fd6437ebb branch July 1, 2026 19:49

Uh oh!

Conversation

github-actions Bot commented Jul 1, 2026

What's covered

Test results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

github-actions Bot commented Jul 1, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 1, 2026

🔥 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 1, 2026

🔬 Smoke Test: Copilot PAT Auth — PASS

Uh oh!

github-actions Bot commented Jul 1, 2026

🔍 Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jul 1, 2026

🧪 Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Smoke Test: Copilot BYOK (Direct) Mode

Uh oh!

github-actions Bot commented Jul 1, 2026

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading