-
Notifications
You must be signed in to change notification settings - Fork 857
Move to slnx #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Move to slnx #374
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Solution> | ||
| <Configurations> | ||
| <Platform Name="Any CPU" /> | ||
| <Platform Name="x64" /> | ||
| <Platform Name="x86" /> | ||
| </Configurations> | ||
| <Folder Name="/src/"> | ||
| <Project Path="src/GitHub.Copilot.SDK.csproj" /> | ||
| </Folder> | ||
| <Folder Name="/test/"> | ||
| <Project Path="test/GitHub.Copilot.SDK.Test.csproj" /> | ||
| </Folder> | ||
| </Solution> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the .sln removed, repo workflows that run
dotnet restore,dotnet format, anddotnet buildfrom the./dotnetdirectory rely on implicit solution/project discovery (e.g..github/workflows/dotnet-sdk-tests.yml:56-70).dotnetCLI commonly does not recognize.slnxas a build entrypoint, so these commands may start failing with “couldn’t find a project or solution file”. To keep CI/dev flows working, either keep the.slnalongside the.slnx, or update the affected scripts/workflows to pass explicit project/solution arguments (e.g., targetsrc/GitHub.Copilot.SDK.csproj/test/GitHub.Copilot.SDK.Test.csproj, and pointdotnet formatat the same).