fix: boolean check for LINK_TO_PROFILE #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINK_TO_PROFILE is read/set as boolean but compared against string Signed-off-by: Pavan Raga <[email protected]>
Contributor
Author
|
Hi @jmeridth Can you please take a look on this? |
Signed-off-by: Pavan Raga <[email protected]>
Member
|
@PavanRaga Thank you for the contribution. Code change looks good. Once you've pushed fix for linting, we can approve and merge. |
Signed-off-by: Pavan Raga <[email protected]>
jmeridth
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK_TO_PROFILE is read/set as boolean but compared against string
Pull Request
Proposed Changes
Bug fix for an input not taking effect
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenanceorbreaking