Remove --external-repository-token option from runner #395
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
approved these changes
Feb 16, 2021
Specifying a token as a cli input leads to a potential for leaking the token on CI logs. This commit removes the option. Instead, users should specify a single GitHub token through `--github-auth-stdin` or by setting the `GITHUB_TOKEN` environment variable. This token should be created with enough privileges to access the required repository.
78e7bd8 to
58defc0
Compare
chrisgavin
approved these changes
Feb 16, 2021
This was referenced Feb 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a token as a cli input leads to a potential for leaking the
token on CI logs. This commit removes the option. Instead, users
should specify a single GitHub token through
--github-auth-stdinorby setting the
GITHUB_TOKENenvironment variable. This token should becreated with enough privileges to access the required repository.
Merge / deployment checklist
Note: This change is not backwards compatible, but because this PR removes a feature that is not yet documented, the risk of removal is low.