Add FF to force JGit-based Git backend#3938
Open
henrymercer wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new feature flag that allows the action to force the CodeQL CLI to use the JGit-based Git backend, providing an emergency override if the git CLI-based backend causes issues.
Changes:
- Add
Feature.ForceJGit(force_jgit) with env-var overrideCODEQL_ACTION_FORCE_JGIT. - When the flag is enabled, export
CODEQL_GIT_BACKEND=jgitduringinitso subsequent CodeQL CLI invocations use JGit. - Update the generated
lib/entry-points.jsto reflect the TypeScript changes.
Show a summary per file
| File | Description |
|---|---|
src/init-action.ts |
Exports CODEQL_GIT_BACKEND=jgit when the new feature flag is enabled. |
src/feature-flags.ts |
Defines the new ForceJGit feature flag and its configuration/env var override. |
lib/entry-points.js |
Generated output updated to match the TypeScript source changes. |
Copilot's findings
- Files reviewed: 2/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a feature flag to force Git client selection to use the JGit Git backend. This is an emergency override in case of problems with the
gitCLI based backend.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist