This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Merged
Conversation
plus fix a few other spacing opportunities
Contributor
Author
When authoring a review
Contributor
Author
|
ok, I'm going to take a step back from this pull request for real 😛 One thing I'm stuck on and could use some guidance is how to change the expander arrow/triangle to the default version that (I assume) we get from Visual Studio: I believe the ones we use here are the triangle down octicons But I'd rather use the ones we see in the headers for each section (next to "Description," "Reviewers," etc) By using the default expander triangle, we'll fit better with the Visual Studio UI brand. Also hoping it's less code to maintain in the long run 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







There's still a handful of things to address still, but I wanted to get these in sooner than later.
I think one of the last things to fix here is making the dropdown triangle the same color as
VsBrush.WindowKey. However, I want to use the same type of triangle seen in other places inside of Visual Studio:Screenshots