fix: no-relative-imports fails with windows paths #11615
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rettend is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows path compatibility issues in the no-relative-imports ESLint plugin by replacing hardcoded forward slashes with proper Node.js path methods.
Key Changes
- Introduced a
normalize()function to ensure consistent cross-platform path representation using forward slashes internally - Refactored
findTsConfigDirectory()to usepath.dirname()instead of string splitting on forward slashes - Applied normalization to path comparisons throughout the
PathEntryclass
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/no-relative-imports/src/paths.ts | Added normalize() helper function and applied it to path comparisons in PathEntry class to ensure consistent forward-slash representation across platforms |
| packages/no-relative-imports/src/noRelativeImportPaths.ts | Refactored findTsConfigDirectory() to use path.resolve() and path.dirname() instead of string manipulation, eliminating hardcoded forward slash assumptions |
| const configStat = statSync(configPath); | ||
| if (configStat.isFile()) break; | ||
| if (configStat.isFile()) return current; | ||
| } catch (_) { |
There was a problem hiding this comment.
'_' is defined but never used.
Suggested change
| } catch (_) { | |
| } catch { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Windows, and I just cloned the repo, install, ran the test script, and it failed.
So I fixed some hardcoded forward slashes by using node:path.
Now every test passes locally