Implement pthread_cond_t with Win32 CONDITION_VARIABLE by rongjiecomputer · Pull Request #1214 · git-for-windows/git

rongjiecomputer · 2017-06-22T01:06:00Z

Win32 CONDITION_VARIABLE has better performance and is easier to maintain.

Since CONDITION_VARIABLE is not available in Windows XP and below, old implementation of pthread_cond_t is kept under define guard 'GIT_WIN_XP_SUPPORT'. To enable old implementation, build with make CFLAGS="-DGIT_WIN_XP_SUPPORT".

If I build with make CFLAGS="-D_WIN32_WINNT=0x0600 or change the define in git-compat-util.h, I will get many warnings and errors about symbols in compat/poll/poll.h are redefined because winsock2.h define them already when _WIN32_WINNT=0x0600.

I choose the simpler solution: keep the old _WIN32_WINNT and declare the 4 required Win32 functions in pthread.c.

Win32 CONDITION_VARIABLE has better performance and is easier to maintain. Since CONDITION_VARIABLE is not available in Windows XP and below, old implementation of pthread_cond_t is kept under define guard 'GIT_WIN_XP_SUPPORT'. To enable old implementation, build with make CFLAGS="-DGIT_WIN_XP_SUPPORT". Signed-off-by: Loo Rong Jie <loorongjie@gmail.com> fast-forwarded.

Signed-off-by: Loo Rong Jie <loorongjie@gmail.com>

rongjiecomputer · 2017-06-23T14:37:08Z

See also for bumping bumped _WINNT_VER to 0x600: #1188 (comment)

rongjiecomputer · 2017-07-03T12:32:06Z

@dscho Ping?

compat/win32/pthread.c

 	return t;
 }

+#ifdef GIT_WIN_XP_SUPPORT


Signed-off-by: Loo Rong Jie <loorongjie@gmail.com>

dscho · 2017-08-15T11:17:04Z

Thank you so much!

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

The XP-compatibility layer emulating pthreads (which is [no longer needed](https://git-for-windows.github.io/requirements.html) [was dropped in favor of modern Windows threading APIs](git-for-windows/git#1214); This should make threaded operations slightly faster and more robust. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

rongjiecomputer added 2 commits June 22, 2017 09:03

Format to 80 cols

617fa0f

Signed-off-by: Loo Rong Jie <loorongjie@gmail.com>

whoisj reviewed Jul 7, 2017

View reviewed changes

Remove old code and macro-ize implementation

e426067

Signed-off-by: Loo Rong Jie <loorongjie@gmail.com>

dscho merged commit eead5ec into git-for-windows:master Aug 15, 2017

dscho added a commit that referenced this pull request Aug 15, 2017

Merge pull request #1214 from rongjiecomputer/master

01101c5

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Aug 18, 2017

Merge pull request #1214 from rongjiecomputer/master

12ef5c4

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 18, 2017

Merge pull request #1214 from rongjiecomputer/master

266422c

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 20, 2017

Merge pull request #1214 from rongjiecomputer/master

a18e1d3

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Aug 22, 2017

Merge pull request #1214 from rongjiecomputer/master

eaae45c

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 23, 2017

Merge pull request #1214 from rongjiecomputer/master

7580452

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2017

Merge pull request #1214 from rongjiecomputer/master

ca70ca2

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2017

Merge pull request #1214 from rongjiecomputer/master

c8960b0

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2017

Merge pull request #1214 from rongjiecomputer/master

97136f5

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2017

Merge pull request #1214 from rongjiecomputer/master

1b581a2

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 25, 2017

Merge pull request #1214 from rongjiecomputer/master

f819886

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Aug 25, 2017

Merge pull request #1214 from rongjiecomputer/master

2b90790

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Aug 26, 2017

Merge pull request #1214 from rongjiecomputer/master

4ff90c1

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Sep 20, 2017

Merge pull request #1214 from rongjiecomputer/master

a150843

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Sep 20, 2017

Merge pull request #1214 from rongjiecomputer/master

02e63bd

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Sep 21, 2017

Merge pull request #1214 from rongjiecomputer/master

bbc3a75

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Sep 21, 2017

Merge pull request #1214 from rongjiecomputer/master

01bdf11

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Sep 26, 2017

Merge pull request #1214 from rongjiecomputer/master

2726f04

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Sep 26, 2017

Merge pull request #1214 from rongjiecomputer/master

bbe64e2

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Sep 26, 2017

Merge pull request #1214 from rongjiecomputer/master

77632ac

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 17, 2017

Merge pull request #1214 from rongjiecomputer/master

b346d7c

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 19, 2017

Merge pull request #1214 from rongjiecomputer/master

310c950

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 19, 2017

Merge pull request #1214 from rongjiecomputer/master

39d7c78

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 19, 2017

Merge pull request #1214 from rongjiecomputer/master

85f1a22

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 19, 2017

Merge pull request #1214 from rongjiecomputer/master

942f152

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 19, 2017

Merge pull request #1214 from rongjiecomputer/master

9f64a5b

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Oct 20, 2017

Merge pull request #1214 from rongjiecomputer/master

54e87d5

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Oct 20, 2017

Merge pull request #1214 from rongjiecomputer/master

fe029ec

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Oct 20, 2017

Merge pull request #1214 from rongjiecomputer/master

9ce0f82

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 20, 2017

Merge pull request #1214 from rongjiecomputer/master

4dae8eb

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2017

Merge pull request #1214 from rongjiecomputer/master

457d66b

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 23, 2017

Merge pull request #1214 from rongjiecomputer/master

4531de1

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Oct 24, 2017

Merge pull request #1214 from rongjiecomputer/master

c89ec07

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Oct 30, 2017

Merge pull request #1214 from rongjiecomputer/master

4b38511

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Nov 1, 2017

Merge pull request #1214 from rongjiecomputer/master

4acbfae

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Nov 6, 2017

Merge pull request #1214 from rongjiecomputer/master

fbfb3d8

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Nov 7, 2017

Merge pull request #1214 from rongjiecomputer/master

f454ba1

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Nov 29, 2017

Merge pull request #1214 from rongjiecomputer/master

9396bbb

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

git-for-windows-ci pushed a commit that referenced this pull request Dec 6, 2017

Merge pull request #1214 from rongjiecomputer/master

b616305

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

dscho added a commit that referenced this pull request Jan 2, 2018

Merge pull request #1214 from rongjiecomputer/master

6f1bfba

Implement pthread_cond_t with Win32 CONDITION_VARIABLE

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement pthread_cond_t with Win32 CONDITION_VARIABLE#1214

Implement pthread_cond_t with Win32 CONDITION_VARIABLE#1214
dscho merged 3 commits intogit-for-windows:masterfrom
rongjiecomputer:master

rongjiecomputer commented Jun 22, 2017

Uh oh!

rongjiecomputer commented Jun 23, 2017

Uh oh!

rongjiecomputer commented Jul 3, 2017

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

dscho commented Aug 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rongjiecomputer commented Jun 22, 2017

Uh oh!

rongjiecomputer commented Jun 23, 2017

Uh oh!

rongjiecomputer commented Jul 3, 2017

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

dscho commented Aug 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants