Skip to content

Conversation

@gistrec
Copy link
Owner

@gistrec gistrec commented Dec 3, 2025

Summary

  • migrate the VK Ads landing endpoint to FastAPI with inline HTML rendering and uvicorn startup
  • shorten VK Ads tokens to 32-character hex strings and update the schema and docs accordingly
  • refresh dependencies and docs for the FastAPI-based landing server

Testing

  • not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

utils/vk_ads.py Outdated
Comment on lines 28 to 31
params = {
"id": VK_COUNTER_ID,
"e": f"RG%3A0/{goal}",
"rb_clickid": click.rb_clickid,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid double-encoding VK Ads goal parameter

The Mail.ru tracker call is built with e=f"RG%3A0/{goal}", but httpx URL-encodes params again, so the request goes out as e=RG%253A0%2FstartBot (verified with httpx.Request(...).url), not the documented e=RG%3A0/startBot shown in README. That double-encoding means every VK Ads start payload sends an unrecognized goal value, so conversion tracking is likely dropped.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants