Skip to content

llama : fix codeshell support (#8250) - #8599

Merged
ggerganov merged 4 commits into
ggml-org:masterfrom
WisdomShell:merge-to-upstream-v2
Jul 22, 2024
Merged

llama : fix codeshell support (#8250)#8599
ggerganov merged 4 commits into
ggml-org:masterfrom
WisdomShell:merge-to-upstream-v2

Conversation

@hankeke303

@hankeke303 hankeke303 commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Hi, @ggerganov

We submitted support for CodeShell in PR #5016, but with the update of llama.cpp, there were some issues with CodeShell support (We have reported this in Issue #8250). This PR aims to sync with the latest version of the repository and fix these issues.

@github-actions github-actions Bot added the python python script changes label Jul 20, 2024
@ggerganov

Copy link
Copy Markdown
Member

After resolving the conflict from #8609, we can merge

@hankeke303

hankeke303 commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

After resolving the conflict from #8609, we can merge

@ggerganov We have resolve this conflict. Please review and approve it again.

Thanks for taking some time to review it!

Comment thread src/llama.cpp Outdated
Comment thread src/llama.cpp Outdated
@hankeke303

Copy link
Copy Markdown
Contributor Author

@ggerganov Sorry for not noticing the order before, we have corrected it.

@ggerganov
ggerganov merged commit 081fe43 into ggml-org:master Jul 22, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* llama : fix codeshell support

* llama : move codeshell after smollm below to respect the enum order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants