[SYCL] Add freq factors support to sycl rope operation#7495
Merged
abhilash1910 merged 1 commit intoggml-org:masterfrom May 27, 2024
Merged
[SYCL] Add freq factors support to sycl rope operation#7495abhilash1910 merged 1 commit intoggml-org:masterfrom
abhilash1910 merged 1 commit intoggml-org:masterfrom
Conversation
NeoZhangJianyu
approved these changes
May 24, 2024
Collaborator
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
The UT case of ROPE are passed on Arc 770.
It's good!
Contributor
|
Phi-3-medium-128k-instruct-Q8_0.gguf works fine |
16b3d96 to
9ac5bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for freq factors for the ROPE operation. The approach is based on the CUDA implementation.
All rope tests are passing on intel PVC and Nvidia A100 for the SYCL backend.