Skip to content

cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q#5772

Merged
ggerganov merged 3 commits into
masterfrom
feature/server-mul-mat-q
Mar 1, 2024
Merged

cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q#5772
ggerganov merged 3 commits into
masterfrom
feature/server-mul-mat-q

Conversation

@phymbert

@phymbert phymbert commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

Cleanup deprecated not used params.mul_mat_q and related docs. It can make confusion for user trying to optmize GPU inference performance: #3359 and #3412 .

Breaking upstream application if any using it.

@phymbert
phymbert requested a review from ggerganov February 28, 2024 17:05
@slaren

slaren commented Feb 28, 2024

Copy link
Copy Markdown
Member

This option is no longer supported, and should be removed completely instead.

@phymbert
phymbert marked this pull request as draft February 28, 2024 17:15
@phymbert

Copy link
Copy Markdown
Collaborator Author

@slaren Thanks, I did not checked :/, I will clean it up it then.

@phymbert
phymbert force-pushed the feature/server-mul-mat-q branch from b4b0d53 to 2e64897 Compare February 28, 2024 17:34
@phymbert phymbert changed the title server: docs: --no-mul-mat-q,-nommq cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q Feb 28, 2024
@phymbert phymbert added the breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility. label Feb 28, 2024
@phymbert
phymbert marked this pull request as ready for review February 28, 2024 17:37
Comment thread examples/batched-bench/batched-bench.cpp
@phymbert

phymbert commented Mar 1, 2024

Copy link
Copy Markdown
Collaborator Author

@ggerganov Hi, as I got one approval, should I wait for yours ? thanks

@ggerganov
ggerganov merged commit 3ab8b3a into master Mar 1, 2024
@phymbert
phymbert deleted the feature/server-mul-mat-q branch March 1, 2024 13:11
hazelnutcloud pushed a commit to hazelnutcloud/llama.cpp that referenced this pull request Mar 10, 2024
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* cleanup unused --no-mul-mat-q,-nommq, -mmq, --mul-mat-q, mul_mat_q

* remove: mul_mat_q in compare llama bench and usage

* update llama-bench

---------

Co-authored-by: slaren <slarengh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants