gemma : use more bits for the token_embd.weight tensor#5650
Merged
Conversation
4 tasks
Member
|
I imagine that for models that share the same tensor for |
|
#5651 as well |
Member
Author
I changed it as suggested. Did a couple of ppl runs with Gemma 2B: For comparison, this is the PPL on Also, here is the speed on M2 Ultra using different types for the tensor:
build: 488bd97 (2232) |
|
@ggerganov , FYI: llama-cpp-python does not work for gemma gguf either |
cebtenzzre
pushed a commit
to nomic-ai/llama.cpp
that referenced
this pull request
Feb 22, 2024
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type (cherry picked from commit 96633ee) Signed-off-by: Jared Van Bortel <jared@nomic.ai>
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
my-other-github-account
pushed a commit
to my-other-github-account/llama.cpp
that referenced
this pull request
May 15, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
my-other-github-account
pushed a commit
to my-other-github-account/llama.cpp
that referenced
this pull request
May 15, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
* gemma : use Q8_0 for the token_embd.weight tensor * llama : quantize token_embd.weight using output type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on some anecdotal runs with Q4 quantizations, it seems that the quality of the generated responses is very sensitive to the type of the
token_embd.weighttensor:Quantizing this tensor to
Q8_0seems like a safe bet. Thought, there might be better strategies