Skip to content

mtmd: dsocr-tiles fixes#25481

Merged
ngxson merged 3 commits into
ggml-org:xsn/mtmd_ds_ocr_tilesfrom
sfallah:sf/pr24717-tiles-fixes
Jul 9, 2026
Merged

mtmd: dsocr-tiles fixes#25481
ngxson merged 3 commits into
ggml-org:xsn/mtmd_ds_ocr_tilesfrom
sfallah:sf/pr24717-tiles-fixes

Conversation

@sfallah

@sfallah sfallah commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
  • ds-ocr img-preproc fuse_row tile-drop fix for multi rows and columns images
  • mtmd drop the duplicate redundant img_end
  • deepseekocr graph simplify CLS broadcast cleanup

AI usage disclosure: YES - I used AI assistance for code review, debugging, implementation checks, and testing. I have reviewed the submitted changes and take responsibility for the full contents of this PR.

@sfallah sfallah requested a review from a team as a code owner July 9, 2026 11:17
@github-actions github-actions Bot added the mtmd Related to multimodal functionality (video/image/audio) label Jul 9, 2026

@ngxson ngxson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I completely forgot the initial PR, will get it finished today

@ngxson ngxson merged commit e5d8b46 into ggml-org:xsn/mtmd_ds_ocr_tiles Jul 9, 2026
1 check passed
@sfallah sfallah deleted the sf/pr24717-tiles-fixes branch July 9, 2026 12:55
ngxson added a commit that referenced this pull request Jul 10, 2026
* mtmd: deepseek-ocr v1 multi-tile dynamic resolution + unified image-preprocessors for both versions (ds-ocr v1 and v2)

* remove hacky API

* fuse row into a long image

* almost working

* adapt to new preprocessor api

* rm debugging printf

* improve

* mtmd: dsocr-tiles fixes (#25481)

* ds-ocr img-preproc fuse_row tile-drop fix for multi rows and columns images

* mtmd drop the duplicate redundant img_end

* deepseekocr graph simplify CLS broadcast cleanup

* test-deepseek-ocr: relax v1 single-view tolerance; drop trailing prompt space; make DRY opt-in and n_predict model-specific (#25486)

---------

Co-authored-by: Saba Fallah <10401143+sfallah@users.noreply.github.com>
Co-authored-by: Saba Fallah <sabafallah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mtmd Related to multimodal functionality (video/image/audio)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants