llama-completion: respect chat_template_kwargs and reasoning_format params#25201
Open
percontation wants to merge 1 commit into
Open
llama-completion: respect chat_template_kwargs and reasoning_format params#25201percontation wants to merge 1 commit into
percontation wants to merge 1 commit into
Conversation
a6c03bb to
dc4bfd3
Compare
Contributor
Author
|
Update: This PR now only applies to llama-completion, and no longer applies to llama-cli because #24948 also fixed this (by removing the llama-cli specific codepaths that failed to pass params properly). |
percontation
commented
Jul 8, 2026
|
|
||
| // note: the time for chat template initialization is not negligible: | ||
| auto chat_templates = common_chat_templates_init(model, params.chat_template); | ||
| const bool template_supports_thinking = params.use_jinja && common_chat_templates_support_enable_thinking(chat_templates.get()); |
Contributor
Author
There was a problem hiding this comment.
FWIW: this template_supports_thinking logic (plus its use below for enable_reasoning) is copied directly from server-context.cpp, for consistency with how other llama.cpp tools process these args.
dc4bfd3 to
da72143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
llama-completion will now respect
--chat-template-kwargs,--reasoning, and--reasoning-formatargs.llama-completion was previously accepting & ignoring
--reasoningand--reasoning-format, and not accepting--chat-template-kwargs.Requirements