server: fix report progress for loading spec models, add "stages" list - #24870
Merged
Conversation
4 tasks
ServeurpersoCom
approved these changes
Jun 21, 2026
atmosfar
reviewed
Jun 23, 2026
| // optionally reserve VRAM for the draft / MTP context before fitting the target model | ||
| if (params_base.fit_params) { | ||
| if (callback_state) { | ||
| callback_state(SERVER_STATE_LOADING, {{"stage", "fit_params"}}); |
There was a problem hiding this comment.
just curious why fit_params was removed from SSE?
Collaborator
Author
There was a problem hiding this comment.
- the time it takes is negligible
- it doesn't actually report %, removed to make sure everything can now report as %
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
ggml-org#24870) * server: fix report progress for loading spec models, add "stages" list * improve * nits * nits 2
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
ggml-org#24870) * server: fix report progress for loading spec models, add "stages" list * improve * nits * nits 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #24828
loading event now look like this:
cc @ServeurpersoCom
Requirements