Skip to content

[SYCL] Add conv_3d#24691

Merged
ggerganov merged 6 commits into
ggml-org:masterfrom
arthw:add_conv_3d
Jun 17, 2026
Merged

[SYCL] Add conv_3d#24691
ggerganov merged 6 commits into
ggml-org:masterfrom
arthw:add_conv_3d

Conversation

@arthw

@arthw arthw commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Add conv_3d
Update ops.md
All related cases are verified successfully.

@arthw arthw requested a review from a team as a code owner June 16, 2026 15:10
@github-actions github-actions Bot added documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jun 16, 2026
@arthw arthw added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 17, 2026
Comment thread ggml/src/ggml-sycl/conv3d.hpp Outdated
Comment on lines +1 to +11
//
// MIT license
// Copyright (C) 2026 Intel Corporation
// SPDX-License-Identifier: MIT
//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthw Please remove these copyright notices from the sources - they don't serve any purpose and only cause confusion. All copyrights are listed in the AUTHORS file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will remove them.

Thank you!

@ggerganov ggerganov merged commit d1759e4 into ggml-org:master Jun 17, 2026
27 of 29 checks passed
papamoose pushed a commit to papamoose/llama.cpp that referenced this pull request Jun 27, 2026
* add conv_3d

* optimize

* update ops.md

* restore test script

* rm unused code

* rm copyright notes
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
* add conv_3d

* optimize

* update ops.md

* restore test script

* rm unused code

* rm copyright notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants