fix: symbol collision for ggml_vec_dot_q4_1_q8_1 when building for wasm#24639
Merged
Conversation
ggerganov
approved these changes
Jun 15, 2026
am17an
pushed a commit
to am17an/llama.cpp
that referenced
this pull request
Jun 20, 2026
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #22209
ggml_vec_dot_q4_1_q8_1_genericis renamed here for wasm builds even thoughggml_vec_dot_q4_1_q8_1was recently implemented inwasm/quants.c, this breaks builds withCMAKE_SYSTEM_PROCESSOR=wasm.Requirements