Skip to content

Add cohere2moe to llama-vocab for TINY_AYA - #24601

Merged
pwilkin merged 1 commit into
ggml-org:masterfrom
bartowski1182:cohere2moe
Jun 14, 2026
Merged

Add cohere2moe to llama-vocab for TINY_AYA#24601
pwilkin merged 1 commit into
ggml-org:masterfrom
bartowski1182:cohere2moe

Conversation

@bartowski1182

Copy link
Copy Markdown
Contributor

Overview

cohere2moe is missing from llama-vocap.cpp, resulting in it not being recognized and not loading

Requirements

@bartowski1182
bartowski1182 marked this pull request as ready for review June 14, 2026 04:37
@bartowski1182
bartowski1182 requested a review from CISC as a code owner June 14, 2026 04:37
@bartowski1182

Copy link
Copy Markdown
Contributor Author

@pwilkin @CISC adding it where needed so at least it loads, can't be sure if it's proper cause like I mentioned in #24260 the output is not great even at bf16, but not sure if that's the model itself or if it's the code. Can consider the implementation later, but for now might as well let the model load at all

@CISC CISC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, guess that got lost during the back-and-forth!

@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 14, 2026
@pwilkin
pwilkin merged commit 8ed274e into ggml-org:master Jun 14, 2026
25 checks passed
kinchahoy pushed a commit to kinchahoy/llama.cpp that referenced this pull request Jun 16, 2026
am17an pushed a commit to am17an/llama.cpp that referenced this pull request Jun 20, 2026
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants