Skip to content

ci : unbreak release harder#24545

Merged
CISC merged 3 commits into
masterfrom
cisc/ci-release-line-continuation
Jun 12, 2026
Merged

ci : unbreak release harder#24545
CISC merged 3 commits into
masterfrom
cisc/ci-release-line-continuation

Conversation

@CISC

@CISC CISC commented Jun 12, 2026

Copy link
Copy Markdown
Member

Overview

cont #23871

Additional information

Some release builds broke due to missing line continuation.

Requirements

@CISC CISC requested a review from a team as a code owner June 12, 2026 20:45
@CISC CISC changed the title unbreak release harder ci : unbreak release harder Jun 12, 2026
@github-actions github-actions Bot added the devops improvements to build systems and github actions label Jun 12, 2026
@CISC

CISC commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@CISC

CISC commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

That should hopefully do the trick, @allozaur can add the missing test later.

@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 12, 2026
@CISC CISC requested a review from ServeurpersoCom June 12, 2026 21:07
@ngxson

ngxson commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Should we have a specific "language disclosure" for @CISC 😂

@CISC CISC merged commit f58bad4 into master Jun 12, 2026
3 checks passed
@CISC CISC deleted the cisc/ci-release-line-continuation branch June 12, 2026 21:49
@CISC

CISC commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Should we have a specific "language disclosure" for @CISC 😂

Now you know I will next time...

@CISC

CISC commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

That should hopefully do the trick, @allozaur can add the missing test later.

I'm guessing this test is what generates the missing build.json that are breaking builds now that the HF bucket is up-to-date.

@aldehir

aldehir commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Looks like LLAMA_BUILD_NUMBER has to be set for npm run build to generate build.json.

          LLAMA_UI_VERSION: ${{ inputs.hf_ui_version || 'b0000' }}

Probably intended to be LLAMA_BUILD_NUMBER in ui-build.yml.

am17an pushed a commit to am17an/llama.cpp that referenced this pull request Jun 20, 2026
* unbreak release harder

* missed one

* remove missing test for now
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
* unbreak release harder

* missed one

* remove missing test for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants