args: add --video-* CLI arguments#24318
Draft
ngxson wants to merge 3 commits into
Draft
Conversation
ServeurpersoCom
approved these changes
Jun 8, 2026
ggerganov
reviewed
Jun 9, 2026
Comment on lines
+129
to
+131
| // note: setter is NOT thread-safe, should only be called on application startup | ||
| MTMD_API struct mtmd_helper_video_init_params mtmd_helper_video_get_default_params(void); | ||
| MTMD_API void mtmd_helper_video_set_default_params(struct mtmd_helper_video_init_params params); |
Member
There was a problem hiding this comment.
IMO it would be cleaner if we pass the video init params to the mtmd_helper_bitmap_init_from_buf function explicitly instead of having a global set of parameters.
Collaborator
Author
There was a problem hiding this comment.
that would require changing quite a lot of code on llama-server, but on second thought, I think it may worth the effort
temporary changing this to draft now
ngxson
marked this pull request as draft
June 9, 2026 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As discussed in #24269 , add these new arguments to CLI:
--video-fps--video-timestamp-interval--video-ffmpeg-dirAlso ran
llama-gen-docsto sync the docsRequirements