Skip to content

Add NVFP4 MTP scale tensors#23563

Merged
CISC merged 3 commits into
ggml-org:masterfrom
michaelw9999:nvfp4-mtp
May 23, 2026
Merged

Add NVFP4 MTP scale tensors#23563
CISC merged 3 commits into
ggml-org:masterfrom
michaelw9999:nvfp4-mtp

Conversation

@michaelw9999

Copy link
Copy Markdown
Contributor

This PR adds the additional MTP NVFP4 weight scale and input scale tensors for:
eh_proj
shared_head_head

The latest update of remap_nvfp4_tensor_name() in #21095 will map mtp.layers.x.eh_proj.x, if quantized as NVFP4 to the corresponding:

blk.{n}.nextn.eh_proj.scale
blk.{n}.nextn.eh_proj.input_scale

If those scale tensors are present in the GGUF, the newly created model will fail to load without this PR. Conversely, NVFP4/MTP models will not work without this.

I posted a working NVFP4 with MTP model here: Qwen3.5-9B-NVFP4-MTP-GGUF

Yes: AI was used to help test this implementation.

@michaelw9999 michaelw9999 requested a review from CISC as a code owner May 23, 2026 07:59
@github-actions github-actions Bot added the model Model specific label May 23, 2026
Comment thread src/llama-model.h
@CISC CISC requested a review from am17an May 23, 2026 09:38
@CISC CISC merged commit b0df4c0 into ggml-org:master May 23, 2026
33 of 49 checks passed
kashif pushed a commit to kashif/llama.cpp that referenced this pull request May 23, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr
spiritbuun referenced this pull request in spiritbuun/buun-llama-cpp May 25, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr
@michaelw9999 michaelw9999 deleted the nvfp4-mtp branch June 2, 2026 02:12
turbo-tan pushed a commit to turbo-tan/llama.cpp-tq3 that referenced this pull request Jun 2, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr
TheTom pushed a commit to TheTom/llama-cpp-turboquant that referenced this pull request Jun 8, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr

(cherry picked from commit b0df4c0)
zbrad pushed a commit to zbrad/llama.cpp that referenced this pull request Jul 3, 2026
* Add NVFP4 MTP scale tensors

* Link Qwen3.5 MTP tensors

* Aligned nullptr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Model specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants