Add comment line support to --api-key-file#23168
Merged
ngxson merged 1 commit intoJun 19, 2026
Merged
Conversation
|
Hi @kucharskim, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
kucharskim
force-pushed
the
comments-and-api-keys-kucharskim-p2
branch
from
May 16, 2026 23:14
ec9967c to
7e65ae4
Compare
kucharskim
force-pushed
the
comments-and-api-keys-kucharskim-p2
branch
from
May 16, 2026 23:17
7e65ae4 to
6977ca8
Compare
kucharskim
marked this pull request as draft
May 16, 2026 23:19
Contributor
Author
|
If you support only one pull request per person, then I would like first #23167 to be reviewed. This one can wait. |
kucharskim
force-pushed
the
comments-and-api-keys-kucharskim-p2
branch
from
May 28, 2026 16:32
6977ca8 to
359b6ea
Compare
kucharskim
marked this pull request as ready for review
May 28, 2026 16:32
Contributor
Author
|
This is ready for review. |
allozaur
approved these changes
May 28, 2026
ngxson
requested changes
May 28, 2026
| | `--rerank, --reranking` | enable reranking endpoint on server (default: disabled)<br/>(env: LLAMA_ARG_RERANKING) | | ||
| | `--api-key KEY` | API key to use for authentication, multiple keys can be provided as a comma-separated list (default: none)<br/>(env: LLAMA_API_KEY) | | ||
| | `--api-key-file FNAME` | path to file containing API keys, one per line (default: none)<br/>(env: LLAMA_ARG_API_KEY_FILE) | | ||
| | `--api-key-file FNAME` | path to file containing API keys, one per line; lines starting with a hash are treated as comments (default: none)<br/>(env: LLAMA_ARG_API_KEY_FILE) | |
Collaborator
There was a problem hiding this comment.
this table is autogenerated, do not edit it directly
Contributor
Author
There was a problem hiding this comment.
Hm. Can you give me quick pointer how to regenerate it and where is the source of truth for this table?
Contributor
Author
There was a problem hiding this comment.
I edited it by hand, but I found the source of truth for the table. I hope it's okay as is.
kucharskim
force-pushed
the
comments-and-api-keys-kucharskim-p2
branch
from
May 28, 2026 20:27
359b6ea to
3f5d5d3
Compare
kucharskim
force-pushed
the
comments-and-api-keys-kucharskim-p2
branch
from
June 19, 2026 12:14
3f5d5d3 to
097e7cf
Compare
Contributor
Author
|
Resolve conflicts. |
ngxson
approved these changes
Jun 19, 2026
pwilkin
approved these changes
Jun 19, 2026
jimbothigpen
added a commit
to jimbothigpen/llama.cpp
that referenced
this pull request
Jun 20, 2026
Absorbs PRs ggml-org#24821 ggml-org#24796 ggml-org#24779 ggml-org#24817 ggml-org#23168 ggml-org#24787 ggml-org#24801 ggml-org#24794 ggml-webgpu F16 toggles, server router/agent refactor, cpp-httplib 0.48.0, utf8 windows fix, docker UI build. No conflicts with our custom backends.
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: