Skip to content

ci : Downgrade CUDA versions for compatibility - #22077

Closed
ehfd wants to merge 1 commit into
ggml-org:masterfrom
ehfd:master
Closed

ci : Downgrade CUDA versions for compatibility#22077
ehfd wants to merge 1 commit into
ggml-org:masterfrom
ehfd:master

Conversation

@ehfd

@ehfd ehfd commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Follow-up to #21122; fix #21122 (comment).

@CISC @taronaeo

Additional information

Fix various forms of installed environments by reducing the CUDA version of Docker containers, from 12.8.1 to 12.5.1 for CUDA 12, and 13.1.1 to 13.0.1 for CUDA 13.

Requirements

@ehfd
ehfd requested review from a team and ngxson as code owners April 18, 2026 08:19
Copilot AI review requested due to automatic review settings April 18, 2026 08:19
@CISC

CISC commented Apr 18, 2026

Copy link
Copy Markdown
Member

Part of the point of bumping to 12.8.x was also to support Blackwell on CUDA12, at some point people will just have to update their drivers or build their own images if they can't.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the CUDA versions used for Docker/CI builds to improve compatibility with installed environments, following up on #21122 feedback.

Changes:

  • Downgrade CUDA 12 container builds from 12.8.1 to 12.5.1 in CI and default Dockerfile args.
  • Downgrade CUDA 13 container builds from 13.1.1 to 13.0.1 in CI build matrix.
  • Update Docker documentation to reflect the new CUDA image versions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/docker.md Updates the documented CUDA_VERSION default behavior/version(s) for Docker images.
.github/workflows/docker.yml Adjusts CI build matrix to build CUDA 12/13 images with downgraded CUDA versions.
.devops/cuda.Dockerfile Changes the default CUDA_VERSION build arg to 12.5.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/docker.md Outdated
Comment thread .devops/cuda.Dockerfile
@ehfd

ehfd commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

Yeah, I am also conflicted on this matter.

But I guess Blackwell folks are more likely to use CUDA 13?

@ehfd

ehfd commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

Yeah, after some more thinking, I won't proceed.

@ehfd ehfd closed this Apr 18, 2026
@github-actions github-actions Bot added documentation Improvements or additions to documentation devops improvements to build systems and github actions labels Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants