Fix WebUI thinking mode request handling - #21657
Closed
redyuan43 wants to merge 2 commits into
Closed
Conversation
|
Hi @redyuan43, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
allozaur
requested changes
May 4, 2026
| // Strip reasoning content from context before sending | ||
| excludeReasoningFromContext?: boolean; | ||
| // Thinking behavior for supported models | ||
| thinking?: 'auto' | 'on' | 'off'; |
| let { onSave, initialSection }: Props = $props(); | ||
|
|
||
| const settingSections: Array<{ | ||
| type ModelFamily = 'gemma' | 'qwen' | 'unknown'; |
Comment on lines
+56
to
+120
| const SAMPLING_PRESET_TRACKED_KEYS = [ | ||
| SETTINGS_KEYS.TEMPERATURE, | ||
| SETTINGS_KEYS.TOP_K, | ||
| SETTINGS_KEYS.TOP_P, | ||
| SETTINGS_KEYS.MIN_P, | ||
| SETTINGS_KEYS.REPEAT_PENALTY, | ||
| SETTINGS_KEYS.PRESENCE_PENALTY | ||
| ] as const; | ||
|
|
||
| const SAMPLING_PRESET_CONFIG: Record< | ||
| Exclude<ModelFamily, 'unknown'>, | ||
| Record<Exclude<SamplingPresetMode, 'custom'>, SamplingPresetConfig> | ||
| > = { | ||
| gemma: { | ||
| general: { | ||
| temperature: 1.0, | ||
| top_k: 64, | ||
| top_p: 0.95 | ||
| }, | ||
| precise: { | ||
| temperature: 0.2, | ||
| top_k: 64, | ||
| top_p: 0.95 | ||
| } | ||
| }, | ||
| qwen: { | ||
| general: { | ||
| temperature: 1.0, | ||
| top_k: 20, | ||
| top_p: 0.95, | ||
| min_p: 0.0, | ||
| repeat_penalty: 1.0, | ||
| presence_penalty: 1.5 | ||
| }, | ||
| precise: { | ||
| temperature: 0.6, | ||
| top_k: 20, | ||
| top_p: 0.95, | ||
| min_p: 0.0, | ||
| repeat_penalty: 1.0, | ||
| presence_penalty: 0.0 | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| const SAMPLING_PRESET_OPTIONS: Record< | ||
| ModelFamily, | ||
| Array<{ value: SamplingPresetMode; label: string }> | ||
| > = { | ||
| gemma: [ | ||
| { value: 'general', label: 'General (Gemma chat)' }, | ||
| { value: 'precise', label: 'Precise (Gemma code/facts)' }, | ||
| { value: 'custom', label: 'Custom' } | ||
| ], | ||
| qwen: [ | ||
| { value: 'general', label: 'General (Qwen chat)' }, | ||
| { value: 'precise', label: 'Precise (Qwen code)' }, | ||
| { value: 'custom', label: 'Custom' } | ||
| ], | ||
| unknown: [ | ||
| { value: 'general', label: 'General' }, | ||
| { value: 'precise', label: 'Precise' }, | ||
| { value: 'custom', label: 'Custom' } | ||
| ] | ||
| }; |
Contributor
There was a problem hiding this comment.
these constants should be moved to $lib/constants
Contributor
There was a problem hiding this comment.
Also, I feel that this presets logic could be encapsulated in a hook in $lib/hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing