Skip to content

arg: fix incorrect default for backend sampling - #21210

Closed
Galunid wants to merge 1 commit into
ggml-org:masterfrom
Galunid:fix-arg
Closed

arg: fix incorrect default for backend sampling#21210
Galunid wants to merge 1 commit into
ggml-org:masterfrom
Galunid:fix-arg

Conversation

@Galunid

@Galunid Galunid commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Overview

backend sampling was enabled, despite --help saying otherwise. It's been enabled since January, so I left the default as is and updated the docs. Let me know if you want backend sampling disabled, or experimental label removed

Requirements

@Galunid
Galunid requested a review from a team as a code owner March 31, 2026 06:22
@ggml-gh-bot

This comment was marked as off-topic.

@Galunid

Galunid commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

It is a mistake, I had multiple merged PRs in this repository (although none recently).

@ggerganov

Copy link
Copy Markdown
Member

I don't think it is enabled by default:

llama.cpp/common/common.h

Lines 290 to 292 in c3a1128

bool backend_sampling = false;

Most likely the issue is some disconnect between the backend parameters and the webui. Likely related to #18781. I think @allozaur is looking into this.

@Galunid

Galunid commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

That's possible, I retested with a different client and backend sampling was disabled, so it's related to webui.

@Galunid Galunid closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants